Test failures on windows

[ViralBShah]

Describe the bug 🐞

Some lapack tests fail on Windows

Minimal Reproducible Example 👇

Happens in Pkg.test()

Error & Stacktrace ⚠️

[CVODES ERROR]  CVode
  At t = 0 and h = 0, the corrector convergence test failed repeatedly or with |h| = hmin.


[IDAS ERROR]  IDACalcIC
  Newton/Linesearch algorithm failed to converge.

Preconditioners: Error During Test at C:\Users\Viral\.julia\packages\Sundials\ixqpi\test\runtests.jl:85
  Got exception outside of a @test
  LoadError: ArgumentError: invalid argument #4 to LAPACK call
  Stacktrace:
    [1] chklapackerror
      @ C:\Users\Viral\.julia\juliaup\julia-1.11.6+0.x64.w64.mingw32\share\julia\stdlib\v1.11\LinearAlgebra\src\lapack.jl:38 [inlined]
    [2] gesdd!(job::Char, A::Matrix{Float64})
      @ LinearAlgebra.LAPACK C:\Users\Viral\.julia\juliaup\julia-1.11.6+0.x64.w64.mingw32\share\julia\stdlib\v1.11\LinearAlgebra\src\lapack.jl:1714
    [3] _svd!
      @ C:\Users\Viral\.julia\juliaup\julia-1.11.6+0.x64.w64.mingw32\share\julia\stdlib\v1.11\LinearAlgebra\src\svd.jl:125 [inlined]
    [4] svd!(A::Matrix{Float64}; full::Bool, alg::LinearAlgebra.DivideAndConquer)
      @ LinearAlgebra C:\Users\Viral\.julia\juliaup\julia-1.11.6+0.x64.w64.mingw32\share\julia\stdlib\v1.11\LinearAlgebra\src\svd.jl:105
    [5] svd!
      @ C:\Users\Viral\.julia\juliaup\julia-1.11.6+0.x64.w64.mingw32\share\julia\stdlib\v1.11\LinearAlgebra\src\svd.jl:100 [inlined]
    [6] svd(A::Matrix{Float64}; full::Bool, alg::LinearAlgebra.DivideAndConquer)
      @ LinearAlgebra C:\Users\Viral\.julia\juliaup\julia-1.11.6+0.x64.w64.mingw32\share\julia\stdlib\v1.11\LinearAlgebra\src\svd.jl:179
    [7] svd
      @ C:\Users\Viral\.julia\juliaup\julia-1.11.6+0.x64.w64.mingw32\share\julia\stdlib\v1.11\LinearAlgebra\src\svd.jl:178 [inlined]
    [8] pinv(A::Matrix{Float64}; atol::Float64, rtol::Float64)
      @ LinearAlgebra C:\Users\Viral\.julia\juliaup\julia-1.11.6+0.x64.w64.mingw32\share\julia\stdlib\v1.11\LinearAlgebra\src\dense.jl:1562
    [9] pinv
      @ C:\Users\Viral\.julia\juliaup\julia-1.11.6+0.x64.w64.mingw32\share\julia\stdlib\v1.11\LinearAlgebra\src\dense.jl:1546 [inlined]
   [10] AlgebraicMultigrid.Pinv{Float64}(A::SparseMatrixCSC{Float64, Int64})
      @ AlgebraicMultigrid C:\Users\Viral\.julia\packages\AlgebraicMultigrid\5k9uh\src\multilevel.jl:63
   [11] Pinv
      @ C:\Users\Viral\.julia\packages\AlgebraicMultigrid\5k9uh\src\multilevel.jl:65 [inlined]
   [12] ruge_stuben(_A::SparseMatrixCSC{Float64, Int64}, ::Type{Val{1}}; strength::AlgebraicMultigrid.Classical{Float64}, CF::AlgebraicMultigrid.RS, presmoother::AlgebraicMultigrid.Jacobi{Float64, Vector{Float64}}, postsmoother::AlgebraicMultigrid.Jacobi{Float64, Vector{Float64}}, max_levels::Int64, max_coarse::Int64, coarse_solver::Type{AlgebraicMultigrid.Pinv}, kwargs::@Kwargs{})
      @ AlgebraicMultigrid C:\Users\Viral\.julia\packages\AlgebraicMultigrid\5k9uh\src\classical.jl:35
   [13] ruge_stuben
      @ C:\Users\Viral\.julia\packages\AlgebraicMultigrid\5k9uh\src\classical.jl:2 [inlined]
   [14] top-level scope
      @ C:\Users\Viral\.julia\packages\Sundials\ixqpi\test\common_interface\precs.jl:90
   [15] include(fname::String)
      @ Main .\sysimg.jl:38
   [16] macro expansion
      @ C:\Users\Viral\.julia\packages\Sundials\ixqpi\test\runtests.jl:86 [inlined]
   [17] macro expansion
      @ C:\Users\Viral\.julia\juliaup\julia-1.11.6+0.x64.w64.mingw32\share\julia\stdlib\v1.11\Test\src\Test.jl:1709 [inlined]
   [18] macro expansion
      @ C:\Users\Viral\.julia\packages\Sundials\ixqpi\test\runtests.jl:86 [inlined]
   [19] macro expansion
      @ C:\Users\Viral\.julia\juliaup\julia-1.11.6+0.x64.w64.mingw32\share\julia\stdlib\v1.11\Test\src\Test.jl:1709 [inlined]
   [20] top-level scope
      @ C:\Users\Viral\.julia\packages\Sundials\ixqpi\test\runtests.jl:61
   [21] include(fname::String)
      @ Main .\sysimg.jl:38
   [22] top-level scope
      @ none:6
  in expression starting at C:\Users\Viral\.julia\packages\Sundials\ixqpi\test\common_interface\precs.jl:90
Test Summary:     | Pass  Error  Total     Time
Common Interface  |   76      1     77  2m01.3s
  CVODE           |   30            30    32.6s
  ARKODE          |    5             5    11.9s
  IDA             |   16            16    29.7s
  Jacobians       |    9             9    14.2s
  Callbacks       |    9             9    13.9s
  Iterator        |    5             5     1.3s
  Errors          |    1             1     2.7s
  Mass Matrix     |    1             1     5.2s
  Preconditioners |           1      1     9.7s
ERROR: LoadError: Some tests did not pass: 76 passed, 0 failed, 1 errored, 0 broken.
in expression starting at C:\Users\Viral\.julia\packages\Sundials\ixqpi\test\runtests.jl:60
ERROR: Package Sundials errored during testing

[ChrisRackauckas]

That's not related. AlgebraicMultigrid.jl just has issues since it uses pinv when it shouldn't need to... I'd ignore that.

[ViralBShah]

Ok - should we mark that test as broken then?

[ChrisRackauckas]

No because they aren't always broken. AlgebraicMultigrid seems to be using uninitialized memory or something. So this is a mixture of @oscardssmith 's Prec interface and AlgebraicMultigrid doing unsafe things.

[ChrisRackauckas]

Can just follow up here: JuliaLinearAlgebra/AlgebraicMultigrid.jl#121

But that's an upstream thing.