The ExplicitImports check_no_implicit_imports check is currently marked @test_broken (ei_broken = (:no_implicit_imports,)) in two QA environments:
RecursiveArrayTools (root, test/QA/qa.jl)RecursiveArrayToolsRaggedArrays (lib/RecursiveArrayToolsRaggedArrays/test/qa/qa.jl)
Both modules rely on whole-module using of dependencies (LinearAlgebra, SymbolicIndexingInterface, ArrayInterface, StaticArraysCore, Adapt, ...) that implicitly bring dozens of names into scope. Making every used name an explicit import is a sizable source refactor that is out of scope for the QA harness conversion (run_qa v1.6 + ExplicitImports), so the check is tracked as @test_broken here rather than hard-failing the QA lane.
Resolution: convert the whole-module using X statements to explicit using X: a, b, c imports of the names actually used, then drop :no_implicit_imports from each env's ei_broken.
This issue is auto-tracking: run_qa's ei_broken records Broken while the finding stands and flips to an Unexpected Pass (error) once the check is clean, prompting removal of the marker.
The ExplicitImports
check_no_implicit_importscheck is currently marked@test_broken(ei_broken = (:no_implicit_imports,)) in two QA environments:RecursiveArrayTools(root,test/QA/qa.jl)RecursiveArrayToolsRaggedArrays(lib/RecursiveArrayToolsRaggedArrays/test/qa/qa.jl)Both modules rely on whole-module
usingof dependencies (LinearAlgebra,SymbolicIndexingInterface,ArrayInterface,StaticArraysCore,Adapt, ...) that implicitly bring dozens of names into scope. Making every used name an explicit import is a sizable source refactor that is out of scope for the QA harness conversion (run_qa v1.6 + ExplicitImports), so the check is tracked as@test_brokenhere rather than hard-failing the QA lane.Resolution: convert the whole-module
using Xstatements to explicitusing X: a, b, cimports of the names actually used, then drop:no_implicit_importsfrom each env'sei_broken.This issue is auto-tracking:
run_qa'sei_brokenrecordsBrokenwhile the finding stands and flips to anUnexpected Pass(error) once the check is clean, prompting removal of the marker.