fix(tests): resolve O(dx^2) initial condition residual in DAE tests#585
Draft
utkuyilmaz1903 wants to merge 2 commits into
Draft
fix(tests): resolve O(dx^2) initial condition residual in DAE tests#585utkuyilmaz1903 wants to merge 2 commits into
utkuyilmaz1903 wants to merge 2 commits into
Conversation
Contributor
Author
|
I think patching solve calls individually is not a clean approach. I will take a closer look at this soon. |
utkuyilmaz1903
force-pushed
the
fix/dae-initialization-residual
branch
from
bd99344 to
0838616
Compare
… for implicit DAEs
utkuyilmaz1903
force-pushed
the
fix/dae-initialization-residual
branch
from
0838616 to
71fffbf
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a stacked PR. It currently includes commits from #584 to pass CI. Once #584 is merged, this PR will rebase to show only the DAE initialization fix.