Skip to content

Deprecation warnings due to the deprecation of u_modified! #613

Description

@Kolaru

On master (and on the latest release) the package often generate deprecation warnings due to the deprecation of u_modified!.

I wanted to open a PR, as it seems rather easy to fix, but I was confused by the following comment

# SciMLBase v3 renamed `u_modified!` to `derivative_discontinuity!` and internal
# callback code now calls the new name. Define the method when available so
# callbacks keep working on v3. Guarded so the file still loads on v2.

So I am not sure what should be done there, especially considering that the compat in Project.toml is limited to SciML v3, which seems to contradict this comment to me.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Fields

    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions