diff --git a/Project.toml b/Project.toml index 020f25c..f1ce318 100644 --- a/Project.toml +++ b/Project.toml @@ -10,7 +10,6 @@ SpecialFunctions = "276daf66-3868-5448-9aa4-cd146d93841b" [compat] ADTypes = "1" -ExplicitImports = "1" LinearAlgebra = "1" OrdinaryDiffEq = "6, 7" OrdinaryDiffEqSDIRK = "1, 2" @@ -24,7 +23,6 @@ julia = "1.10" [extras] ADTypes = "47edcb42-4c32-4615-8424-f2b9edc5f35b" -ExplicitImports = "7d51a73a-1435-4ff3-83d9-f097790105c7" OrdinaryDiffEq = "1dea7af3-3e70-54e6-95c3-0bf5283fa5ed" OrdinaryDiffEqSDIRK = "2d112036-d095-4a1e-ab9a-08536f3ecdbf" SafeTestsets = "1bc83da4-3b8d-516f-aca4-4fe02f6d838f" @@ -32,4 +30,4 @@ SciMLTesting = "09d9d899-5365-40a9-917a-5f67fddea283" Test = "8dfed614-e22c-5e08-85e1-65c5234f0b40" [targets] -test = ["ADTypes", "ExplicitImports", "Test", "OrdinaryDiffEq", "OrdinaryDiffEqSDIRK", "SafeTestsets", "SciMLTesting"] +test = ["ADTypes", "Test", "OrdinaryDiffEq", "OrdinaryDiffEqSDIRK", "SafeTestsets", "SciMLTesting"] diff --git a/test/core.jl b/test/core.jl index a77d777..ded2af7 100644 --- a/test/core.jl +++ b/test/core.jl @@ -3,10 +3,6 @@ using Test FEniCS.set_log_level(FEniCS.WARNING) -@testset "Explicit Imports" begin - include("explicit_imports.jl") -end - examples_dir = joinpath(@__DIR__, "..", "examples") @assert ispath(examples_dir) example_filenames = readdir(examples_dir) diff --git a/test/explicit_imports.jl b/test/explicit_imports.jl deleted file mode 100644 index 92bcde5..0000000 --- a/test/explicit_imports.jl +++ /dev/null @@ -1,8 +0,0 @@ -using ExplicitImports -using FEniCS -using Test - -@testset "ExplicitImports" begin - @test check_no_implicit_imports(FEniCS) === nothing - @test check_no_stale_explicit_imports(FEniCS) === nothing -end diff --git a/test/qa/Project.toml b/test/qa/Project.toml index 55d7844..f8c6d5f 100644 --- a/test/qa/Project.toml +++ b/test/qa/Project.toml @@ -13,6 +13,6 @@ FEniCS = {path = "../.."} Aqua = "0.8" JET = "0.9,0.10,0.11" SafeTestsets = "0.1, 1" -SciMLTesting = "1" +SciMLTesting = "1.6" Test = "1" julia = "1.10" diff --git a/test/qa/qa.jl b/test/qa/qa.jl index 3cd50d1..12778c6 100644 --- a/test/qa/qa.jl +++ b/test/qa/qa.jl @@ -1,9 +1,14 @@ -using FEniCS, Aqua, JET, Test +using SciMLTesting, FEniCS, Test +using JET -@testset "Aqua" begin - Aqua.test_all(FEniCS) -end - -@testset "JET" begin - JET.test_package(FEniCS; target_defined_modules = true) -end +run_qa( + FEniCS; + explicit_imports = true, + ei_kwargs = (; + # `getdoc` is not public in `Base.Docs`, but FEniCS extends + # `Base.Docs.getdoc(::fenicsobject)` (src/FEniCS.jl) to surface the wrapped + # PyObject's docstring. Extending a Base-internal method legitimately + # requires naming it; nothing to make public here. + all_qualified_accesses_are_public = (; ignore = (:getdoc,)), + ), +)