From 4c4a0e40ea63aadd5348b8b88b088e8226d3441d Mon Sep 17 00:00:00 2001 From: "Chris Rackauckas (Claude)" Date: Sat, 13 Jun 2026 04:55:44 -0400 Subject: [PATCH] QA: restore Aqua deps_compat (add missing [compat] for test extras) The grouped-tests CI conversion added `Pkg` to [extras]/[targets].test without a corresponding [compat] entry, which trips Aqua's test_deps_compat extras sub-check. Instead of weakening the check (check_extras=false + a @test_broken false sentinel), add the missing `Pkg = "1"` compat bound and restore the full `Aqua.test_deps_compat(EllipsisNotation)` call. Co-Authored-By: Chris Rackauckas Co-Authored-By: Claude Opus 4.8 (1M context) --- Project.toml | 1 + test/qa.jl | 5 +---- 2 files changed, 2 insertions(+), 4 deletions(-) diff --git a/Project.toml b/Project.toml index b7aba51..aae951a 100644 --- a/Project.toml +++ b/Project.toml @@ -9,6 +9,7 @@ StaticArrayInterface = "0d7ed370-da01-4f52-bd93-41d350b8b718" [compat] AllocCheck = "0.2" +Pkg = "1" PrecompileTools = "1.0.1" SafeTestsets = "0.1" StaticArrayInterface = "1.2.1" diff --git a/test/qa.jl b/test/qa.jl index 0b11858..704bac5 100644 --- a/test/qa.jl +++ b/test/qa.jl @@ -3,10 +3,7 @@ using EllipsisNotation, Aqua @testset "Aqua" begin Aqua.find_persistent_tasks_deps(EllipsisNotation) Aqua.test_ambiguities(EllipsisNotation, recursive = false) - Aqua.test_deps_compat(EllipsisNotation, check_extras = false) - # Aqua deps_compat extras check: `Pkg` is in [extras]/[targets].test without a [compat] entry. - # Tracked in https://github.com/SciML/EllipsisNotation.jl/issues/113 - @test_broken false + Aqua.test_deps_compat(EllipsisNotation) Aqua.test_piracies(EllipsisNotation) Aqua.test_project_extras(EllipsisNotation) Aqua.test_stale_deps(EllipsisNotation)