From 065151457256b9d93efa4dc477f67de6a031c0fd Mon Sep 17 00:00:00 2001 From: ChrisRackauckas-Claude Date: Wed, 3 Jun 2026 12:33:46 -0400 Subject: [PATCH] Centralize CI on SciML reusable workflows Convert inline CI workflows to the centralized SciML/.github reusable callers (pinned @v1, secrets: "inherit") and fix two comment typos. - FormatCheck (Runic): inline fredrikekre/runic-action -> runic.yml@v1 - SpellCheck (typos): inline crate-ci/typos -> spellcheck.yml@v1 - Downgrade: inline -> downgrade.yml@v1 (preserve if:false, julia 1.10, skip Pkg,TOML, allow-reresolve false) - Tests (CI.yml) and Documentation already central callers; unchanged - Remove CompatHelper.yml - dependabot: drop crate-ci/typos ignore block - Fix typos: "sensitity"->"sensitivity", "repalced"->"replaced" Co-Authored-By: Chris Rackauckas Co-Authored-By: Claude Opus 4.8 (1M context) --- .github/dependabot.yml | 3 --- .github/workflows/CompatHelper.yml | 17 ----------------- .github/workflows/Downgrade.yml | 24 +++++++----------------- .github/workflows/FormatCheck.yml | 12 +++--------- .github/workflows/SpellCheck.yml | 10 +++------- src/algorithms/linear.jl | 2 +- src/utilities.jl | 2 +- 7 files changed, 15 insertions(+), 55 deletions(-) delete mode 100644 .github/workflows/CompatHelper.yml diff --git a/.github/dependabot.yml b/.github/dependabot.yml index cd7b7f2..f901dd8 100644 --- a/.github/dependabot.yml +++ b/.github/dependabot.yml @@ -5,9 +5,6 @@ updates: directory: "/" # Location of package manifests schedule: interval: "weekly" - ignore: - - dependency-name: "crate-ci/typos" - update-types: ["version-update:semver-patch", "version-update:semver-minor"] - package-ecosystem: "julia" directories: - "/" diff --git a/.github/workflows/CompatHelper.yml b/.github/workflows/CompatHelper.yml deleted file mode 100644 index 796825a..0000000 --- a/.github/workflows/CompatHelper.yml +++ /dev/null @@ -1,17 +0,0 @@ -name: CompatHelper -on: - schedule: - - cron: '00 00 * * *' - workflow_dispatch: -jobs: - CompatHelper: - runs-on: ubuntu-latest - steps: - - name: Pkg.add("CompatHelper") - run: julia -e 'using Pkg; Pkg.add("CompatHelper")' - - name: CompatHelper.main() - env: - GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} - COMPATHELPER_PRIV: ${{ secrets.COMPATHELPER_PRIV }} - run: julia -e 'using CompatHelper; CompatHelper.main(;subdirs=["", "docs"])' - \ No newline at end of file diff --git a/.github/workflows/Downgrade.yml b/.github/workflows/Downgrade.yml index b700a13..dc64198 100644 --- a/.github/workflows/Downgrade.yml +++ b/.github/workflows/Downgrade.yml @@ -13,20 +13,10 @@ on: jobs: test: if: false # Disabled: PrecompileTools compatibility. See #149 for details. - runs-on: ubuntu-latest - strategy: - matrix: - downgrade_mode: ['alldeps'] - julia-version: ['1.10'] - steps: - - uses: actions/checkout@v6 - - uses: julia-actions/setup-julia@v3 - with: - version: ${{ matrix.julia-version }} - - uses: julia-actions/julia-downgrade-compat@v2 - with: - skip: Pkg,TOML - - uses: julia-actions/julia-buildpkg@v1 - - uses: julia-actions/julia-runtest@v1 - with: - ALLOW_RERESOLVE: false \ No newline at end of file + name: "Downgrade" + uses: "SciML/.github/.github/workflows/downgrade.yml@v1" + with: + julia-version: "1.10" + skip: "Pkg,TOML" + allow-reresolve: false + secrets: "inherit" \ No newline at end of file diff --git a/.github/workflows/FormatCheck.yml b/.github/workflows/FormatCheck.yml index ee667ce..32f2e1f 100644 --- a/.github/workflows/FormatCheck.yml +++ b/.github/workflows/FormatCheck.yml @@ -11,12 +11,6 @@ on: jobs: runic: - runs-on: ubuntu-latest - steps: - - uses: actions/checkout@v6 - - uses: julia-actions/setup-julia@v3 - with: - version: '1' - - uses: fredrikekre/runic-action@v1 - with: - version: '1' + name: "Runic" + uses: "SciML/.github/.github/workflows/runic.yml@v1" + secrets: "inherit" diff --git a/.github/workflows/SpellCheck.yml b/.github/workflows/SpellCheck.yml index 746b039..05b2767 100644 --- a/.github/workflows/SpellCheck.yml +++ b/.github/workflows/SpellCheck.yml @@ -4,10 +4,6 @@ on: [pull_request] jobs: typos-check: - name: Spell Check with Typos - runs-on: ubuntu-latest - steps: - - name: Checkout Actions Repository - uses: actions/checkout@v6 - - name: Check spelling - uses: crate-ci/typos@v1.18.0 \ No newline at end of file + name: "Spell Check with Typos" + uses: "SciML/.github/.github/workflows/spellcheck.yml@v1" + secrets: "inherit" \ No newline at end of file diff --git a/src/algorithms/linear.jl b/src/algorithms/linear.jl index f88b386..5ebf387 100644 --- a/src/algorithms/linear.jl +++ b/src/algorithms/linear.jl @@ -52,7 +52,7 @@ function DiffEqBase.__solve( ) end -# Ideally hook into existing sensitity dispatching +# Ideally hook into existing sensitivity dispatching # Trouble with Zygote. The problem isn't the _concrete_solve_adjoint but rather something in the # adjoint of the basic solve and `solve_up`. Probably promotion on the prob diff --git a/src/utilities.jl b/src/utilities.jl index 41a4410..810f7a7 100644 --- a/src/utilities.jl +++ b/src/utilities.jl @@ -121,7 +121,7 @@ end maybe_add_Δ_slice!(Δz, Δsol_A, t) = nothing # Don't add logpdf to observables unless provided -# TODO: check if this can be repalced with the following and if it has a performance regression for diagonal noise covariance +# TODO: check if this can be replaced with the following and if it has a performance regression for diagonal noise covariance # ldiv!(Δz, observables_noise.Σ.chol, innovation[t]) # rmul!(Δlogpdf, Δz) Base.@propagate_inbounds @inline function maybe_add_Δ_logpdf!(