From daa5017cbb52947f42c7f9555db0879915f0efd2 Mon Sep 17 00:00:00 2001 From: Chris Rackauckas Date: Mon, 15 Jun 2026 11:30:58 +0000 Subject: [PATCH] Normalize NoPre test group into canonical QA (rebased on current main) --- test/{NoPre => qa}/Project.toml | 0 test/{NoPre => qa}/qa.jl | 0 test/{NoPre => qa}/test_jet.jl | 0 test/runtests.jl | 20 ++++++++++---------- test/test_groups.toml | 4 ++-- 5 files changed, 12 insertions(+), 12 deletions(-) rename test/{NoPre => qa}/Project.toml (100%) rename test/{NoPre => qa}/qa.jl (100%) rename test/{NoPre => qa}/test_jet.jl (100%) diff --git a/test/NoPre/Project.toml b/test/qa/Project.toml similarity index 100% rename from test/NoPre/Project.toml rename to test/qa/Project.toml diff --git a/test/NoPre/qa.jl b/test/qa/qa.jl similarity index 100% rename from test/NoPre/qa.jl rename to test/qa/qa.jl diff --git a/test/NoPre/test_jet.jl b/test/qa/test_jet.jl similarity index 100% rename from test/NoPre/test_jet.jl rename to test/qa/test_jet.jl diff --git a/test/runtests.jl b/test/runtests.jl index 6869267..f30ce4a 100644 --- a/test/runtests.jl +++ b/test/runtests.jl @@ -2,18 +2,18 @@ using Pkg using SafeTestsets using SciMLTesting -# The NoPre group runs Aqua/JET in the test/NoPre sub-env, but only on a non-prerelease +# The QA group runs Aqua/JET in the test/QA sub-env, but only on a non-prerelease # Julia: those tools produce spurious reports on prerelease builds, so the whole group # (env activation included) is a no-op on a `pre` matrix entry. A folder-discovery body -# cannot express this guard, so NoPre stays an explicit thunk. "Quality" is a legacy -# alias for NoPre. -function nopre_group() +# cannot express this guard, so QA stays an explicit thunk. "Quality" is a legacy +# alias for QA. +function qa_group() isempty(VERSION.prerelease) || return nothing - Pkg.activate(joinpath(@__DIR__, "NoPre")) + Pkg.activate(joinpath(@__DIR__, "qa")) Pkg.develop(PackageSpec(path = dirname(@__DIR__))) Pkg.instantiate() - @safetestset "Quality Assurance" include(joinpath(@__DIR__, "NoPre", "qa.jl")) - @safetestset "JET Static Analysis" include(joinpath(@__DIR__, "NoPre", "test_jet.jl")) + @safetestset "Quality Assurance" include(joinpath(@__DIR__, "qa", "qa.jl")) + @safetestset "JET Static Analysis" include(joinpath(@__DIR__, "qa", "test_jet.jl")) return nothing end @@ -23,9 +23,9 @@ run_tests(; @safetestset "ANTLR Parser Tests" include("test_antlr_parser.jl") return @safetestset "Error Message Tests" include("test_error_messages.jl") end, - groups = Dict("NoPre" => nopre_group), - umbrellas = Dict("Quality" => ["NoPre"]), - # Original runtests ran NoPre/Quality only for those explicit GROUPs, never under + groups = Dict("QA" => qa_group), + umbrellas = Dict("Quality" => ["QA"]), + # Original runtests ran QA/Quality only for those explicit GROUPs, never under # "All"; curate "All" to Core only to preserve that. all = ["Core"], ) diff --git a/test/test_groups.toml b/test/test_groups.toml index 6d5a1fe..1fe84cd 100644 --- a/test/test_groups.toml +++ b/test/test_groups.toml @@ -1,5 +1,5 @@ [Core] versions = ["lts", "1", "pre"] -[NoPre] -versions = ["lts", "1", "pre"] +[QA] +versions = ["lts", "1"]