From /code-review feat/offline-pwa (finding, follow-on to the #2 fix). The wizard now writes collection_date as a full YYYY-MM-DDTHH:mm (issue #6). The sample edit page was fixed to tolerate it (datetime-local + normalizer), but other consumers still assume date-only and should be audited:
- The batch grid (
samples/batch) uses <input type=date> for new rows — fine for creation, but inconsistent capture format across the two entry paths.
- NCBI / MIxS exports — confirm
collection_date with a time component (and no timezone) is accepted by the BioSample/SRA templates and the MIxS LinkML validator; normalize if not.
- Detail views / any date parsing that assumes 10-char
YYYY-MM-DD.
Decide on one canonical stored format (date-only vs date+time, with/without tz) and make all readers/writers agree.
From
/code-review feat/offline-pwa(finding, follow-on to the #2 fix). The wizard now writescollection_dateas a fullYYYY-MM-DDTHH:mm(issue #6). The sample edit page was fixed to tolerate it (datetime-local + normalizer), but other consumers still assume date-only and should be audited:samples/batch) uses<input type=date>for new rows — fine for creation, but inconsistent capture format across the two entry paths.collection_datewith a time component (and no timezone) is accepted by the BioSample/SRA templates and the MIxS LinkML validator; normalize if not.YYYY-MM-DD.Decide on one canonical stored format (date-only vs date+time, with/without tz) and make all readers/writers agree.