Skip to content

fix(bookmarks): open bookmark panel from reminder tap and fix tombstone purge #2744

fix(bookmarks): open bookmark panel from reminder tap and fix tombstone purge

fix(bookmarks): open bookmark panel from reminder tap and fix tombstone purge #2744

Triggered via pull request May 14, 2026 01:07
Status Failure
Total duration 1m 28s
Artifacts

quality-checks.yml

on: pull_request
Fit to window
Zoom out
Zoom in

Annotations

16 errors and 11 warnings
Lint
Process completed with exit code 1.
typescript-eslint(no-redundant-type-constituents): src/app/features/bookmarks/bookmarkRepository.ts#L31
'BookmarkItemContent' is an 'error' type that acts as 'any' and overrides all other types in this union type.
eslint(no-unused-vars): src/app/pages/client/ClientNonUIFeatures.tsx#L65
Identifier 'useReminderSync' is imported but never used.
eslint(no-unused-vars): src/app/pages/client/ClientNonUIFeatures.tsx#L63
Identifier 'useInitBookmarks' is imported but never used.
Build
Process completed with exit code 1.
Knip
Process completed with exit code 1.
Typecheck: src/app/features/bookmarks/bookmarkRepository.ts#L139
Property 'BookmarkItemPrefix' does not exist on type '{ readonly CinnySpaces: "in.cinny.spaces"; readonly ElementRecentEmoji: "io.element.recent_emoji"; readonly PoniesUserEmotes: "im.ponies.user_emotes"; readonly PoniesEmoteRooms: "im.ponies.emote_rooms"; readonly SableNicknames: "moe.sable.app.nicknames"; readonly SablePinStatus: "moe.sable.app.pins_read_marker"; rea...'.
Typecheck: src/app/features/bookmarks/bookmarkRepository.ts#L136
Parameter 'item' implicitly has an 'any' type.
Typecheck: src/app/features/bookmarks/bookmarkRepository.ts#L135
Parameter 'id' implicitly has an 'any' type.
Typecheck: src/app/features/bookmarks/bookmarkRepository.ts#L130
Parameter 'id' implicitly has an 'any' type.
Typecheck: src/app/features/bookmarks/bookmarkRepository.ts#L105
Parameter 'id' implicitly has an 'any' type.
Typecheck: src/app/features/bookmarks/bookmarkRepository.ts#L40
Property 'BookmarksIndex' does not exist on type '{ readonly CinnySpaces: "in.cinny.spaces"; readonly ElementRecentEmoji: "io.element.recent_emoji"; readonly PoniesUserEmotes: "im.ponies.user_emotes"; readonly PoniesEmoteRooms: "im.ponies.emote_rooms"; readonly SableNicknames: "moe.sable.app.nicknames"; readonly SablePinStatus: "moe.sable.app.pins_read_marker"; rea...'.
Typecheck: src/app/features/bookmarks/bookmarkRepository.ts#L35
'content' is possibly 'undefined'.
Typecheck: src/app/features/bookmarks/bookmarkRepository.ts#L25
Property 'BookmarksIndex' does not exist on type '{ readonly CinnySpaces: "in.cinny.spaces"; readonly ElementRecentEmoji: "io.element.recent_emoji"; readonly PoniesUserEmotes: "im.ponies.user_emotes"; readonly PoniesEmoteRooms: "im.ponies.emote_rooms"; readonly SableNicknames: "moe.sable.app.nicknames"; readonly SablePinStatus: "moe.sable.app.pins_read_marker"; rea...'.
Typecheck: src/app/features/bookmarks/bookmarkRepository.ts#L21
Cannot find module './bookmarkDomain' or its corresponding type declarations.
Typecheck: src/app/features/bookmarks/bookmarkRepository.ts#L15
Cannot find module './bookmarkDomain' or its corresponding type declarations.
Lint
Node.js 20 actions are deprecated. The following actions are running on Node.js 20 and may not work as expected: pnpm/action-setup@b906affcce14559ad1aafd4ab0e942779e9f58b1. Actions will be forced to run with Node.js 24 by default starting June 2nd, 2026. Node.js 20 will be removed from the runner on September 16th, 2026. Please check if updated versions of these actions are available that support Node.js 24. To opt into Node.js 24 now, set the FORCE_JAVASCRIPT_ACTIONS_TO_NODE24=true environment variable on the runner or in your workflow file. Once Node.js 24 becomes the default, you can temporarily opt out by setting ACTIONS_ALLOW_USE_UNSECURE_NODE_VERSION=true. For more information see: https://github.blog/changelog/2025-09-19-deprecation-of-node-20-on-github-actions-runners/
typescript-eslint(no-unnecessary-type-assertion): src/app/features/bookmarks/bookmarkRepository.ts#L64
This assertion is unnecessary since it does not change the type of the expression.
typescript-eslint(no-unnecessary-type-assertion): src/app/components/message/content/ImageContent.tsx#L203
This assertion is unnecessary since it does not change the type of the expression.
typescript-eslint(no-unnecessary-type-assertion): src/app/components/message/content/ImageContent.tsx#L203
This assertion is unnecessary since it does not change the type of the expression.
eslint-plugin-unicorn(no-array-sort): src/app/plugins/markdown/markdownToHtml.ts#L80
Use `Array#toSorted()` instead of `Array#sort()`.
Format check
Node.js 20 actions are deprecated. The following actions are running on Node.js 20 and may not work as expected: pnpm/action-setup@b906affcce14559ad1aafd4ab0e942779e9f58b1. Actions will be forced to run with Node.js 24 by default starting June 2nd, 2026. Node.js 20 will be removed from the runner on September 16th, 2026. Please check if updated versions of these actions are available that support Node.js 24. To opt into Node.js 24 now, set the FORCE_JAVASCRIPT_ACTIONS_TO_NODE24=true environment variable on the runner or in your workflow file. Once Node.js 24 becomes the default, you can temporarily opt out by setting ACTIONS_ALLOW_USE_UNSECURE_NODE_VERSION=true. For more information see: https://github.blog/changelog/2025-09-19-deprecation-of-node-20-on-github-actions-runners/
Build
Node.js 20 actions are deprecated. The following actions are running on Node.js 20 and may not work as expected: pnpm/action-setup@b906affcce14559ad1aafd4ab0e942779e9f58b1. Actions will be forced to run with Node.js 24 by default starting June 2nd, 2026. Node.js 20 will be removed from the runner on September 16th, 2026. Please check if updated versions of these actions are available that support Node.js 24. To opt into Node.js 24 now, set the FORCE_JAVASCRIPT_ACTIONS_TO_NODE24=true environment variable on the runner or in your workflow file. Once Node.js 24 becomes the default, you can temporarily opt out by setting ACTIONS_ALLOW_USE_UNSECURE_NODE_VERSION=true. For more information see: https://github.blog/changelog/2025-09-19-deprecation-of-node-20-on-github-actions-runners/
Knip
Node.js 20 actions are deprecated. The following actions are running on Node.js 20 and may not work as expected: pnpm/action-setup@b906affcce14559ad1aafd4ab0e942779e9f58b1. Actions will be forced to run with Node.js 24 by default starting June 2nd, 2026. Node.js 20 will be removed from the runner on September 16th, 2026. Please check if updated versions of these actions are available that support Node.js 24. To opt into Node.js 24 now, set the FORCE_JAVASCRIPT_ACTIONS_TO_NODE24=true environment variable on the runner or in your workflow file. Once Node.js 24 becomes the default, you can temporarily opt out by setting ACTIONS_ALLOW_USE_UNSECURE_NODE_VERSION=true. For more information see: https://github.blog/changelog/2025-09-19-deprecation-of-node-20-on-github-actions-runners/
Tests
Node.js 20 actions are deprecated. The following actions are running on Node.js 20 and may not work as expected: pnpm/action-setup@b906affcce14559ad1aafd4ab0e942779e9f58b1. Actions will be forced to run with Node.js 24 by default starting June 2nd, 2026. Node.js 20 will be removed from the runner on September 16th, 2026. Please check if updated versions of these actions are available that support Node.js 24. To opt into Node.js 24 now, set the FORCE_JAVASCRIPT_ACTIONS_TO_NODE24=true environment variable on the runner or in your workflow file. Once Node.js 24 becomes the default, you can temporarily opt out by setting ACTIONS_ALLOW_USE_UNSECURE_NODE_VERSION=true. For more information see: https://github.blog/changelog/2025-09-19-deprecation-of-node-20-on-github-actions-runners/
Typecheck
Node.js 20 actions are deprecated. The following actions are running on Node.js 20 and may not work as expected: pnpm/action-setup@b906affcce14559ad1aafd4ab0e942779e9f58b1. Actions will be forced to run with Node.js 24 by default starting June 2nd, 2026. Node.js 20 will be removed from the runner on September 16th, 2026. Please check if updated versions of these actions are available that support Node.js 24. To opt into Node.js 24 now, set the FORCE_JAVASCRIPT_ACTIONS_TO_NODE24=true environment variable on the runner or in your workflow file. Once Node.js 24 becomes the default, you can temporarily opt out by setting ACTIONS_ALLOW_USE_UNSECURE_NODE_VERSION=true. For more information see: https://github.blog/changelog/2025-09-19-deprecation-of-node-20-on-github-actions-runners/