This repository was archived by the owner on Nov 19, 2025. It is now read-only.
Pat/resolve review#230
Merged
Merged
Conversation
… SymbolTable::lookup_within()
…vaContext::lookup_within()
failures:
doc::tests::value_declarations
doc::tests::visibility
fightling
force-pushed
the
pat/resolve_review
branch
from
e755bca to
a53c34d
Compare
fightling
force-pushed
the
pat/resolve_review
branch
from
b489f9d to
deb4eab
Compare
fightling
force-pushed
the
pat/resolve_review
branch
from
fcd2885 to
5a7d94b
Compare
failures:
doc::tests::value_declarations
fightling
force-pushed
the
pat/resolve_review
branch
from
513ff61 to
cd8a6d3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Self-review of code mostly in resolve.