fan.py needs to be truncated

[dh4ns3n]

fan.py repeats itself after line 119 and should be truncated there

[dh4ns3n]

As well it is missing the set command used by server.py.
So for example insert at line 114 of fan.py two new lines:

elif cmd == "set" and len(sys.argv) == 3: 
        set_pwm(sys.argv[2])

[Rocketplanner83]

Thanks for raising this.

The duplicate logic in fan.py has been refactored in v1.1. The file has been restructured and the redundant section after line 119 has been removed as part of the control-plane split.

The set command path is now handled through the dedicated control service (truefan-control) rather than being embedded in fan.py. This separation isolates hardware writes from the monitoring service and avoids mixing CLI parsing with runtime logic.

If you are referencing the older monolithic implementation, that behavior has been superseded. Please test against v1.1 and let me know if any functional gaps remain.

[dh4ns3n]

Hmm ok, the code has drastically changed now with your v1.1.
This issue was created to create a working version for the old structure and let it become alive to actually control the fans for me.

Now with v1.1 even after adapting it to my hardware I am not able to control anything.
I have a AOOSTAR WTR Pro (AMD) with TrueNAS installed and the module https://github.com/frankcrawford/it87 compiled for it to get access on the fans.
So I needed to adapt following files:
app/sensors.py (line 75)
if "nct" not in name and "asus" not in name and "it8613" not in name:

turefan-control/hwmon.py (line7)
HWMON_ROOT = "/sys/devices/platform/it87.2608/hwmon"

With those changes and an additional running truefan-control/main.py (configured with the Bearing token), the status report looks like this:
{"agent":{"age_seconds":6.67572021484375e-06,"error":"","last_checked":1771698096.1588454,"online":true,"status_code":200},"agent_available":true,"capabilities":{"smart_available":true},"fan":{"fan2":1054,"fan3":903,"fan4":0},"mode":"full-control","pwm_control_enabled":true,"sensors":[{"name":"cpu","value":39.375},{"name":"nvme","value":46.85},{"name":"hdd","value":35.0}],"system":{"load":"0.04 / 0.07 / 0.08","profile":"cool","uptime":"173h 10m"}}

But no chance to control any fan. Is this the intended status of your v1.1 commit or have I missed the control features?

[Rocketplanner83]

Thanks for the detailed report — this helps.

From your status output:

• agent is online
• pwm_control_enabled is true
• mode is full-control
• RPM telemetry is working

So monitoring is healthy and the control agent is reachable.

If PWM changes are not affecting the fans, this usually means one of the following:

1. The PWM channel is not in manual mode
   Check:

   cat /sys/devices/platform/it87.2608/hwmon/hwmon*/pwm2_enable
   

   Value should be 1 (manual).
   If it is 2 (auto), the BIOS is controlling it.

2. The fan header is not mapped to the PWM index being written
   RPM shows fan2/fan3 active — verify which pwmX corresponds to those inputs.

3. BIOS/firmware is locking fan control
   Some boards expose RPM but ignore writes unless Smart Fan is disabled.

4. The correct hwmon root is not being targeted
   Since you had to hardcode:

   HWMON_ROOT="/sys/devices/platform/it87.2608/hwmon"
   

   please confirm that the pwm files being written are in the same hwmon directory that reports the active fan RPM.

To verify writes are occurring:

echo 120 > /sys/devices/platform/it87.2608/hwmon/hwmonX/pwm2
cat /sys/devices/platform/it87.2608/hwmon/hwmonX/pwm2

If the value changes but RPM does not, the issue is firmware-level control, not the application.

v1.1 does not remove control functionality — it isolates it into the truefan-control service for security reasons. Full control is still supported, but the board/driver must allow manual PWM writes.

If you can share:

• Output of ls inside that hwmon directory
• Values of pwmX_enable
• Which pwm index corresponds to the active fan

we can narrow this precisely.

[dh4ns3n]

The control on os level is working fine, here is the log of my test session:

truenas_admin@truenas[/sys/class/hwmon]$ ls -al
total 0
drwxr-xr-x  2 root root 0 Feb 14 14:11 .
drwxr-xr-x 65 root root 0 Feb 14 14:11 ..
lrwxrwxrwx  1 root root 0 Feb 14 14:11 hwmon0 -> ../../devices/pci0000:00/0000:00:01.1/0000:01:00.0/nvme/nvme0/hwmon0
lrwxrwxrwx  1 root root 0 Feb 14 14:12 hwmon1 -> ../../devices/pci0000:00/0000:00:18.3/hwmon/hwmon1
lrwxrwxrwx  1 root root 0 Feb 14 14:12 hwmon2 -> ../../devices/pci0000:00/0000:00:08.1/0000:04:00.0/hwmon/hwmon2
lrwxrwxrwx  1 root root 0 Feb 14 14:12 hwmon3 -> ../../devices/platform/it87.2608/hwmon/hwmon3
truenas_admin@truenas[/sys/class/hwmon]$ ls ./hwmon3 
alarms      fan2_min    fan4_alarm  in0_beep   in1_beep   in2_beep   in4_beep   in5_beep   in7_beep   in8_input         name                     pwm2_auto_point1_temp_hyst  pwm2_enable              pwm3_auto_point1_temp_hyst  pwm3_enable              pwm4_auto_point1_temp_hyst  pwm4_freq                   pwm5_auto_point2_temp  subsystem    temp1_min     temp2_input   temp3_beep    uevent
device      fan3_alarm  fan4_beep   in0_input  in1_input  in2_input  in4_input  in5_input  in7_input  in8_label         power                    pwm2_auto_point2_temp       pwm2_freq                pwm3_auto_point2_temp       pwm3_freq                pwm4_auto_point2_temp       pwm5                        pwm5_auto_point3_temp  temp1_alarm  temp1_offset  temp2_max     temp3_input
fan2_alarm  fan3_beep   fan4_input  in0_max    in1_max    in2_max    in4_max    in5_max    in7_label  in9_input         pwm2                     pwm2_auto_point3_temp       pwm3                     pwm3_auto_point3_temp       pwm4                     pwm4_auto_point3_temp       pwm5_auto_channels_temp     pwm5_auto_slope        temp1_beep   temp1_type    temp2_min     temp3_max
fan2_beep   fan3_input  fan4_min    in0_min    in1_min    in2_min    in4_min    in5_min    in7_max    in9_label         pwm2_auto_channels_temp  pwm2_auto_slope             pwm3_auto_channels_temp  pwm3_auto_slope             pwm4_auto_channels_temp  pwm4_auto_slope             pwm5_auto_point1_temp       pwm5_enable            temp1_input  temp2_alarm   temp2_offset  temp3_min
fan2_input  fan3_min    in0_alarm   in1_alarm  in2_alarm  in4_alarm  in5_alarm  in7_alarm  in7_min    intrusion0_alarm  pwm2_auto_point1_temp    pwm2_auto_start             pwm3_auto_point1_temp    pwm3_auto_start             pwm4_auto_point1_temp    pwm4_enable                 pwm5_auto_point1_temp_hyst  pwm5_freq              temp1_max    temp2_beep    temp3_alarm   temp3_offset
truenas_admin@truenas[/sys/class/hwmon]$ cat /sys/class/hwmon/hwmon3/pwm2_enable 
2
truenas_admin@truenas[/sys/class/hwmon]$ cat /sys/class/hwmon/hwmon3/pwm3_enable 
2
truenas_admin@truenas[/sys/class/hwmon]$ cat /sys/class/hwmon/hwmon3/pwm4_enable 
2
truenas_admin@truenas[/sys/class/hwmon]$ cat /sys/class/hwmon/hwmon3/pwm5_enable 
1
truenas_admin@truenas[/sys/class/hwmon]$ 
truenas_admin@truenas[/sys/class/hwmon]$ sudo sh -c 'echo 1 > /sys/class/hwmon/hwmon3/pwm2_enable'
truenas_admin@truenas[/sys/class/hwmon]$ cat /sys/class/hwmon/hwmon3/pwm2_enable        
1
truenas_admin@truenas[/sys/class/hwmon]$ cat /sys/class/hwmon/hwmon3/pwm2                  
40
truenas_admin@truenas[/sys/class/hwmon]$ cat /sys/class/hwmon/hwmon3/fan2                  
cat: /sys/class/hwmon/hwmon3/fan2: No such file or directory
truenas_admin@truenas[/sys/class/hwmon]$ cat /sys/class/hwmon/hwmon3/fan2_input 
1059
truenas_admin@truenas[/sys/class/hwmon]$ sudo sh -c 'echo 120 > /sys/class/hwmon/hwmon3/pwm2'     
truenas_admin@truenas[/sys/class/hwmon]$ cat /sys/class/hwmon/hwmon3/fan2_input              
2721
truenas_admin@truenas[/sys/class/hwmon]$ sudo sh -c 'echo 40 > /sys/class/hwmon/hwmon3/pwm2' 
truenas_admin@truenas[/sys/class/hwmon]$ cat /sys/class/hwmon/hwmon3/fan2_input             
1057
truenas_admin@truenas[/sys/class/hwmon]$ cat /sys/class/hwmon/hwmon3/fan3_input 
928
truenas_admin@truenas[/sys/class/hwmon]$ cat /sys/class/hwmon/hwmon3/pwm3                    
130
truenas_admin@truenas[/sys/class/hwmon]$ sudo sh -c 'echo 1 > /sys/class/hwmon/hwmon3/pwm3_enable' 
truenas_admin@truenas[/sys/class/hwmon]$ cat /sys/class/hwmon/hwmon3/pwm3_enable             
1
truenas_admin@truenas[/sys/class/hwmon]$ cat /sys/class/hwmon/hwmon3/pwm3                         
130
truenas_admin@truenas[/sys/class/hwmon]$ cat /sys/class/hwmon/hwmon3/fan3_input                   
794
truenas_admin@truenas[/sys/class/hwmon]$ sudo sh -c 'echo 120 > /sys/class/hwmon/hwmon3/pwm3' 
truenas_admin@truenas[/sys/class/hwmon]$ sudo sh -c 'echo 220 > /sys/class/hwmon/hwmon3/pwm3' 
truenas_admin@truenas[/sys/class/hwmon]$ cat /sys/class/hwmon/hwmon3/fan3_input              
1278
truenas_admin@truenas[/sys/class/hwmon]$ cat /sys/class/hwmon/hwmon3/pwm3                    
220
truenas_admin@truenas[/sys/class/hwmon]$ sudo sh -c 'echo 2 > /sys/class/hwmon/hwmon3/pwm3_enable' 
truenas_admin@truenas[/sys/class/hwmon]$ sudo sh -c 'echo 2 > /sys/class/hwmon/hwmon3/pwm2_enable' 
truenas_admin@truenas[/sys/class/hwmon]$ cat /sys/class/hwmon/hwmon3/fan3_input                   
1418
truenas_admin@truenas[/sys/class/hwmon]$ cat /sys/class/hwmon/hwmon3/fan2_input 
1059
truenas_admin@truenas[/sys/class/hwmon]$ cat /sys/class/hwmon/hwmon3/pwm3                         
220
truenas_admin@truenas[/sys/class/hwmon]$ cat /sys/class/hwmon/hwmon3/pwm2 
40
truenas_admin@truenas[/sys/class/hwmon]$ sudo sh -c 'echo 130 > /sys/class/hwmon/hwmon3/pwm3'  
sh: 1: echo: echo: I/O error
truenas_admin@truenas[/sys/class/hwmon]$ sudo sh -c 'echo 1 > /sys/class/hwmon/hwmon3/pwm3_enable' 
truenas_admin@truenas[/sys/class/hwmon]$ sudo sh -c 'echo 130 > /sys/class/hwmon/hwmon3/pwm3'     
truenas_admin@truenas[/sys/class/hwmon]$ sudo sh -c 'echo 2 > /sys/class/hwmon/hwmon3/pwm3_enable'
truenas_admin@truenas[/sys/class/hwmon]$ cat /sys/class/hwmon/hwmon3/pwm3                    
130
truenas_admin@truenas[/sys/class/hwmon]$ 

As well the mapping is as expected: fanX<->pwmX

What I was referring to with control features, were the UI features from truefan.

My UI only show monitoring capabilities and nothing to control the fans.
If the UI would add these features I will become a truefan of your code ;D