Fix build version to include time for unique per-build versioning - #9
Closed
RobGruhl wants to merge 2 commits into
Closed
Fix build version to include time for unique per-build versioning#9RobGruhl wants to merge 2 commits into
RobGruhl wants to merge 2 commits into
Conversation
This commit implements 16 recommendations from a thorough design and code review: CSS Improvements: - Add CSS custom properties (design tokens) for colors, spacing, and typography - Replace hardcoded values with CSS variables for maintainability - Add utility classes for common patterns (.text-muted, .mt-40, etc.) JavaScript Improvements: - Implement proper error handling with try-catch for JSON parsing - Add input validation for character IDs (alphanumeric, hyphens, underscores only) - Replace innerHTML with safe DOM methods to prevent XSS vulnerabilities - Add DOM element caching to improve query performance - Standardize localStorage key format with constants - Move skill summaries from hardcoded JS object to JSON data file - Add comprehensive JSDoc documentation for all functions - Implement escapeHtml utility function for safe text insertion Accessibility Improvements: - Add ARIA labels and roles throughout template - Add aria-live regions for dynamic content - Add proper nav/main/section semantic structure - Add aria-describedby associations for form controls HTML Template Improvements: - Remove inline styles, use CSS classes instead - Add meta description for SEO - Use hidden attribute instead of style.display Python Generator Improvements: - Add comprehensive error handling with informative messages - Add validation for character ID format - Add HTML structure validation for generated pages - Add docstrings for all functions - Return proper exit codes Testing Infrastructure: - Add tests/test_data_validation.py with 17 test cases - Tests cover data structure, schema validation, and referential integrity - All tests passing Data Improvements: - Add summary field to all 45 skills in JSON data - Maintain single source of truth for skill descriptions
Changed BUILD_VERSION format from YYYY.MM.DD.001 (static .001 suffix) to YYYY.MM.DD.HHMM (includes hours and minutes). This ensures each build gets a unique version number that users can verify in their browser to confirm they're viewing the latest generated pages.
RobGruhl
added a commit
that referenced
this pull request
Nov 24, 2025
Updated build version format from YYYY.MM.DD.001 to YYYY.MM.DD.HHMM to ensure each build has a unique version number when multiple builds occur on the same day. Regenerated all character pages with new format. Incorporates changes from PR #9. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
Owner
Author
|
Changes incorporated directly into main. Build version format updated from YYYY.MM.DD.001 to YYYY.MM.DD.HHMM and all character pages regenerated. |
RobGruhl
deleted the
claude/design-review-improvements-01VHZdJkM3W2os3mrT8XScxw
branch
November 24, 2025 23:56
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.