From 90c33aa7f736ab8e99e0c5129e9dfacfddf79a19 Mon Sep 17 00:00:00 2001
From: Nilanjan Sarkar <73954995+nsbits@users.noreply.github.com>
Date: Tue, 5 Apr 2022 22:14:24 +0530
Subject: [PATCH] Update popularity bias

the denominator should be  `p[:k]`
---
 reclist/metrics/standard_metrics.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/reclist/metrics/standard_metrics.py b/reclist/metrics/standard_metrics.py
index db1323a..35ccffa 100644
--- a/reclist/metrics/standard_metrics.py
+++ b/reclist/metrics/standard_metrics.py
@@ -115,7 +115,7 @@ def popularity_bias_at_k(y_preds, x_train, k=3):
     pop_map = {k:v/num_interactions for k,v in pop_map.items()}
     all_popularity = []
     for p in y_preds:
-        average_pop = sum(pop_map.get(_, 0.0) for _ in p[:k]) / len(p) if len(p) > 0 else 0
+        average_pop = sum(pop_map.get(_, 0.0) for _ in p[:k]) / len(p[:k]) if len(p) > 0 else 0
         all_popularity.append(average_pop)
     return sum(all_popularity) / len(y_preds)