feat: Use Magisk for root installation

[ViVi-Vibes]

Feature description

When using apatch as root manager the apps are not mounted correctly and ends up resetting every reboot. I saw three closed issues and there were no resolution for those issues.

Motivation

The official support for apatch will fix mounting issues : ReVanced/revanced-manager#2440, ReVanced/revanced-manager#2425, ReVanced/revanced-manager#2168 .

Acknowledgements

• The feature request is only related to ReVanced Manager.
• I have chosen an appropriate title.
• I have checked all open and closed feature requests and this is not a duplicate.

[ViVi-Vibes]

Is this issue getting ignored i see other issues being addressed and closed just not with this one 😭 .

[oSumAtrIX]

No

[ViVi-Vibes]

@oSumAtrIX Sorry for ping but i wanna know if this Pull Request could possibly help with the problem.

[oSumAtrIX]

That's a pull request

[Ushie]

@oSumAtrIX Sorry for ping but i wanna know if this Commit could possibly help with the problem.

Not slightly related

[ViVi-Vibes]

That's a pull request

Yeah it's a pull request i meant could we possibly skip mounting and use signature spoofing instead ???

[oSumAtrIX]

Mount is an installation method, signature spoofing is a patch to bypass client side signature checks. Two different things

[Ushie]

According to the starting message of the commit, that requires system-level modification

The user would need to be on a custom rom, that has support for that feature, so not any custom rom, and not a stock rom with root either which is the most typical choice

Maybe if we check what those custom roms change to mimic their implementation just enough for this to work then it may be plausible

[Ushie]

Mount is an installation method, signature spoofing is a patch to bypass client side signature checks. Two different things

Mounting is an installation method that targets not modifying the applications signature, otherwise it's not favored above just normal installation

[Ushie]

Though I think it might be easier and better to fix all issues with mount installation rather than pursuing that

[ViVi-Vibes]

Mount is an installation method, signature spoofing is a patch to bypass client side signature checks. Two different things

Sorry the first message of the commit confused me.

[ViVi-Vibes]

I thought if that would work it could be a better alternative to mount as mount scripts get detected. Though i haven't encountered any detections by any app only native detector detected it.

[ViVi-Vibes]

Also for now i have been using the revanced module by j-hc i know it's not official but it's the only way to mount the apps correctly in aptach rn.