From 6b853036c3088b9ba2796e8cebcb89ba218b148d Mon Sep 17 00:00:00 2001
From: Amit Kumar <ak.nitrr13@gmail.com>
Date: Fri, 24 Apr 2026 17:52:58 +0000
Subject: [PATCH] =?UTF-8?q?fix(build):=20unblock=20mvn=20test=20=E2=80=94?=
 =?UTF-8?q?=20drop=20tsconfig=20baseUrl,=20add=20frontend.skip=20(RAN-27)?=
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

Two related fixes so `mvn test` / `mvn package` run green from a clean
checkout:

1. src/main/frontend/tsconfig.json: remove `"baseUrl": "."`.
   TypeScript 5.7 emits TS5101 (`Option 'baseUrl' is deprecated and
   will stop functioning in TypeScript 7.0`), which aborts `tsc -b`
   inside frontend-maven-plugin's `npm-build` execution and kills
   every Maven build.  Since TS 4.1, `paths` resolves relative to
   the tsconfig's own location, so the existing `"@/*": ["./src/*"]`
   mapping keeps working untouched — and Vite already resolves the
   same alias via `resolve.alias` in `vite.config.ts`.

2. pom.xml: add a `<frontend.skip>` property (default `false`) and
   wire `<skip>${frontend.skip}</skip>` into the frontend-maven-plugin
   configuration.  Backend-only contributors can now run
   `mvn test -Dfrontend.skip=true` and bypass the npm toolchain
   entirely while CI and release builds continue to bundle the SPA.

Acceptance
- `mvn test` green from a clean checkout on main
- `mvn test -Dfrontend.skip=true` skips the npm executions (verified
  locally: all three executions short-circuit, BUILD SUCCESS)
- `npm run build` under `src/main/frontend/` no longer errors on
  TS5101 (the previously blocking diagnostic)

Subsumes RAN-11 / PR #64 (same tsconfig change) and is the complete
fix for the blocker.

Co-Authored-By: Paperclip <noreply@paperclip.ing>
---
 pom.xml                         | 9 +++++++++
 src/main/frontend/tsconfig.json | 1 -
 2 files changed, 9 insertions(+), 1 deletion(-)

diff --git a/pom.xml b/pom.xml
index 691566be..4fa50492 100644
--- a/pom.xml
+++ b/pom.xml
@@ -30,6 +30,14 @@
         <owasp.dependency-check.version>12.2.0</owasp.dependency-check.version>
         <checkstyle-plugin.version>3.6.0</checkstyle-plugin.version>
 
+        <!--
+          Toggle for the frontend-maven-plugin. Defaults to false so
+          `mvn package` still bundles the React SPA. Backend-only
+          contributors can bypass the npm build with:
+            mvn test -Dfrontend.skip=true
+        -->
+        <frontend.skip>false</frontend.skip>
+
         <!--
           Security override: Spring Boot 4.0.5 pulls tomcat-embed-core 11.0.20
           and jackson (tools.jackson.core) 3.1.0; both have CVEs fixed in the
@@ -235,6 +243,7 @@
                 <configuration>
                     <workingDirectory>src/main/frontend</workingDirectory>
                     <nodeVersion>v20.11.0</nodeVersion>
+                    <skip>${frontend.skip}</skip>
                 </configuration>
                 <executions>
                     <execution>
diff --git a/src/main/frontend/tsconfig.json b/src/main/frontend/tsconfig.json
index b02f8c5e..aeca1c9a 100644
--- a/src/main/frontend/tsconfig.json
+++ b/src/main/frontend/tsconfig.json
@@ -17,7 +17,6 @@
     "noImplicitReturns": true,
     "noFallthroughCasesInSwitch": true,
     "forceConsistentCasingInFileNames": true,
-    "baseUrl": ".",
     "paths": {
       "@/*": ["./src/*"]
     }