From 3b7f8eb2f7ed49b623f4db7a6fcb991a5203e1cd Mon Sep 17 00:00:00 2001 From: Igor Beylin Date: Wed, 29 Jul 2026 15:56:48 +0000 Subject: [PATCH] test(api): type register mocks so tsconfig.check.json typecheck passes MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit The `typecheck` gate (tsconfig.check.json, which includes tests/) failed with 3 TS2493 errors: `valuesMock.mock.calls[0][0]` indexed the first insert arg, but valuesMock was `vi.fn(() => …)` with a zero-arg implementation, so its call args were inferred as the empty tuple `[]` — index 0 is a compile error. Declare the argument the mock actually receives (`(_values: Record) => …`) so `mock.calls[0]` is a non-empty tuple. No runtime/behavior change; the register suites still pass (13 tests). This clears the last 3 errors so `npm run typecheck` exits 0. Co-Authored-By: Claude Opus 4.8 Claude-Session: https://claude.ai/code/session_01SjcHn8jZErKo37ZJi6qybX --- tests/api/register-enriched.e2e.test.ts | 2 +- tests/api/register.test.ts | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/tests/api/register-enriched.e2e.test.ts b/tests/api/register-enriched.e2e.test.ts index 72f10d7..d015dc4 100644 --- a/tests/api/register-enriched.e2e.test.ts +++ b/tests/api/register-enriched.e2e.test.ts @@ -4,7 +4,7 @@ import Fastify, { type FastifyInstance } from 'fastify'; const { insertMock, valuesMock, onConflictDoUpdateMock, returningMock } = vi.hoisted(() => { const returningMock = vi.fn(); const onConflictDoUpdateMock = vi.fn(() => ({ returning: returningMock })); - const valuesMock = vi.fn(() => ({ onConflictDoUpdate: onConflictDoUpdateMock })); + const valuesMock = vi.fn((_values: Record) => ({ onConflictDoUpdate: onConflictDoUpdateMock })); const insertMock = vi.fn(() => ({ values: valuesMock })); return { insertMock, valuesMock, onConflictDoUpdateMock, returningMock }; }); diff --git a/tests/api/register.test.ts b/tests/api/register.test.ts index d07dd33..7df6eda 100644 --- a/tests/api/register.test.ts +++ b/tests/api/register.test.ts @@ -5,7 +5,7 @@ import Fastify, { FastifyInstance } from 'fastify'; const { insertMock, valuesMock, onConflictDoUpdateMock, returningMock } = vi.hoisted(() => { const returningMock = vi.fn(); const onConflictDoUpdateMock = vi.fn(() => ({ returning: returningMock })); - const valuesMock = vi.fn(() => ({ onConflictDoUpdate: onConflictDoUpdateMock })); + const valuesMock = vi.fn((_values: Record) => ({ onConflictDoUpdate: onConflictDoUpdateMock })); const insertMock = vi.fn(() => ({ values: valuesMock })); return { insertMock, valuesMock, onConflictDoUpdateMock, returningMock }; });