[codex] add QSL architecture governance docs - #169
Conversation
Co-Authored-By: Codex <noreply@openai.com>
|
Bugbot is not enabled for your account, so this pull request was not reviewed. Enable Bugbot in the Cursor dashboard to get automatic reviews on future PRs. |
🤖 Codex PR ReviewPlease ensure a human reviewer checks this PR before merging. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 394716bd3d
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| UsEquityStrategies = "17ddb86c72d44b2c7b78ba7a10d8f71b21180166" | ||
| HkEquityStrategies = "b6a8ac2ad3c8110b5ea74fb059c8206388d63bcd" | ||
| CnEquityStrategies = "8dfadcf8a4dc6cc516f27a4013248474603d8ce2" | ||
| CnEquityStrategies = "73844e92a8570a61e5a9dc6c245809d0b27b89bc" |
There was a problem hiding this comment.
When a consumer follows the repository's current baseline documentation, this new bundle pin conflicts with docs/qsl_compat_upgrade.md:60, which still lists CnEquityStrategies for bundle 2026.07.2 as 8dfadcf8a4dc6cc516f27a4013248474603d8ce2. That doc is presented as the current central compatibility baseline, so users can pin the documented SHA and then fail check_qsl_compat.py against this manifest, which now expects 73844e92a8570a61e5a9dc6c245809d0b27b89bc.
Useful? React with 👍 / 👎.
| UsEquityStrategies = "17ddb86c72d44b2c7b78ba7a10d8f71b21180166" | ||
| HkEquityStrategies = "b6a8ac2ad3c8110b5ea74fb059c8206388d63bcd" | ||
| CnEquityStrategies = "8dfadcf8a4dc6cc516f27a4013248474603d8ce2" | ||
| CnEquityStrategies = "73844e92a8570a61e5a9dc6c245809d0b27b89bc" |
There was a problem hiding this comment.
This new bundle makes 73844e92a8570a61e5a9dc6c245809d0b27b89bc the expected CnEquityStrategies SHA, but internal_dependency_matrix.json still records QmtPlatform's pyproject.toml and uv.lock CN strategy refs as 8dfadcf8a4dc6cc516f27a4013248474603d8ce2 at lines 271-289. The new governance doc says consumer manifests must match declared bundle pins, so publishing the bundle without updating or exceptioning QmtPlatform leaves the CN runtime platform out of compliance and will keep strict workspace checks failing when that repo is present.
Useful? React with 👍 / 👎.
| Use the compatibility checker as the repo-level contract gate: | ||
|
|
||
| ```bash | ||
| python3 python/scripts/qslctl.py check --repo-root /path/to/repo |
There was a problem hiding this comment.
This command is documented as the repo-level contract gate, but qslctl.py check only exits non-zero when --strict is supplied (python/scripts/qslctl.py:378-384). In CI or release scripts that copy this example, a repository with compatibility issues will print a failing result while the command still exits 0, so the intended gate does not block the bad pin.
Useful? React with 👍 / 👎.
Co-Authored-By: Codex <noreply@openai.com>
|
Bugbot is not enabled for your account, so this pull request was not reviewed. Enable Bugbot in the Cursor dashboard to get automatic reviews on future PRs. |
1 participant
Summary
2026.07.2CN strategy compat pin and dependency matrix.Validation
check_internal_dependency_matrix.py --projects-root /Users/lisiyi/Projects --strictqslctl.py check-all --projects-root /Users/lisiyi/Projects --strictpython3 -m unittest discover -s python/testsnode tests/strategy_switch_worker_validation.mjsRisk