fix(strategy): address review gate findings

Co-Authored-By: Codex <noreply@openai.com>

Author: Pigbibi

scripts/validate_strategy_review.py

@@ -9,6 +9,7 @@
 from typing import Any
 
 STATUSES = {"pass", "fail", "insufficient_evidence", "not_applicable"}
+DECISIONS = {"pass", "fail", "insufficient_evidence"}
 
 
 def validate_review(payload: Any) -> list[str]:
@@ -17,6 +18,8 @@ def validate_review(payload: Any) -> list[str]:
         return ["top-level JSON must be an object"]
     if payload.get("schema_version") != "strategy_review.v1":
         issues.append("schema_version must be strategy_review.v1")
+    if payload.get("decision") not in DECISIONS:
+        issues.append("decision must be pass, fail, or insufficient_evidence")
     if not isinstance(payload.get("profile"), str) or not payload["profile"].strip():
         issues.append("profile must be a non-empty string")
     gates = payload.get("hard_gates")
@@ -45,6 +48,9 @@ def validate_review(payload: Any) -> list[str]:
     else:
         if evidence.get("metrics_kind") != "performance":
             issues.append("evidence.metrics_kind must be performance")
+        for field in ("data_source", "cost_model"):
+            if not isinstance(evidence.get(field), str) or not evidence[field].strip():
+                issues.append(f"evidence.{field} must be a non-empty string")
         if evidence.get("placeholder_metrics") is not False:
             issues.append("placeholder metrics are not admissible evidence")
         if not isinstance(evidence.get("sample_count"), int) or evidence["sample_count"] < 0:

tests/test_strategy_review_validator.py

@@ -54,6 +54,15 @@ def test_pass_cannot_override_failed_gate(self) -> None:
         payload = _review(decision="pass")
         self.assertTrue(any("cannot be pass" in issue for issue in MODULE.validate_review(payload)))
 
+    def test_unknown_decision_is_rejected(self) -> None:
+        self.assertTrue(any("decision must be" in issue for issue in MODULE.validate_review(_review(decision="unknown"))))
+
+    def test_empty_provenance_is_rejected(self) -> None:
+        payload = _review(evidence={**_review()["evidence"], "data_source": "", "cost_model": " "})
+        issues = MODULE.validate_review(payload)
+        self.assertTrue(any("data_source" in issue for issue in issues))
+        self.assertTrue(any("cost_model" in issue for issue in issues))
+
 
 if __name__ == "__main__":
     unittest.main()