Reconcile LongBridge target schedulers

[Pigbibi]

Summary

• honor the current environment's runtime enabled state for its Cloud Run service
• replace the shared monitor dispatcher scheduler with direct per-service prechecks
• pause main and precheck jobs for disabled targets
• preserve canonical precheck jobs during legacy reconciliation

Verification

• focused plan/reconcile tests: 8 passed
• workflow shell contract
• full ruff, uv lock, actionlint, YAML, and diff checks

Existing test debt

The unrestricted local suite has failures already present on origin/main; all tests covering this change pass.

[chatgpt-codex-connector]

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 520893693b

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

• Open a pull request for review
• Mark a draft as ready
• Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

[github-actions]

🤖 Codex PR Review

✅ Merge allowed: 2 finding(s) reported but none are blocking

ℹ️ Other Findings

1. 🟡 [MEDIUM] Logic in scripts/reconcile_cloud_runtime.py

_legacy_jobs_for_target() no longer returns the canonical ${service}-probe-scheduler and ${service}-precheck-scheduler names. The reconcile workflow still runs --delete-legacy-jobs, and the removed test expectations show those exact jobs already exist in multiple legacy regions today. After this change, any stale copies of the canonical probe/precheck jobs outside the active region will never be deleted and will keep firing, causing duplicate probe or dry-run executions for the same target. (line 280)

Suggestion: Keep deleting the canonical ${service}-probe-scheduler and ${service}-precheck-scheduler in legacy regions, but exempt only the current target region instead of dropping those names from legacy cleanup entirely.

2. 🟡 [MEDIUM] Logic in .github/workflows/sync-cloud-run-env.yml

The new cleanup verifier resolves each replacement job's location from per-target fields like scheduler_location and scheduler.location, but the sync job still creates and updates the probe/precheck jobs only in the global CLOUD_SCHEDULER_LOCATION/CLOUD_RUN_REGION location. For any target that uses a target-specific scheduler location, the verifier will look in a different region than the creator, decide the replacements are missing, and skip deleting the shared dispatcher. That leaves both the shared dispatcher and the new per-service jobs active, producing duplicate prechecks. (line 1292)

Suggestion: Resolve scheduler location once with the same precedence in both places. Either teach the sync step to create/update jobs in the target-specific scheduler location, or make the cleanup verifier use the same global-only location if per-target locations are not actually supported.

---

Review by Codex PR Review bot • PR

[chatgpt-codex-connector]

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 44980d5ece

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

• Open a pull request for review
• Mark a draft as ready
• Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

[chatgpt-codex-connector]

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 5885c9b5e3

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

• Open a pull request for review
• Mark a draft as ready
• Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

[chatgpt-codex-connector]

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 7bbe46d940

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

• Open a pull request for review
• Mark a draft as ready
• Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

[Pigbibi]

已在 67a3713 处理最新审查：\n- 不再在单个/部分 sync 中删除 MONITOR_DISPATCH_TARGETS_JSON 兼容变量；旧 dispatcher 仍只在 full configured rollout 且全部替代 job 已存在后删除，消除切换空窗。\n- replacement verifier 增加 CLOUD_SCHEDULER_LOCATION、CLOUD_RUN_REGION fallback。\n- 新增 workflow 回归断言；focused pytest、shell contract、actionlint、ruff、diff check 均通过。