fix: fail closed on IBKR execution readiness - #358
Conversation
Co-Authored-By: Codex <noreply@openai.com>
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 10e368477b
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
@codex review |
Co-Authored-By: Codex <noreply@openai.com>
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: aa01c79152
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Co-Authored-By: Codex <noreply@openai.com>
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 3af2c31ed3
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Co-Authored-By: Codex <noreply@openai.com>
|
@codex review |
|
Codex Review: Didn't find any major issues. Another round soon, please! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
1 participant
Summary
AvailableFundsas cash.Root cause
The runtime could prove API connectivity but not writable order access. It could also receive valid IBKR account data using
$LEDGER-*cash tags while resolving cash to zero, and rejected submissions could be reported as a successful/no-op cycle. Separately, the market calendar raised before the force-run override was evaluated during pre-market verification.Behavior and safety
whatIfOrder; IBKR evaluates commission and margin but does not place the order.execution_status=blocked; runtime reports and heartbeat checks reject it, except for the existing expected safety guards.Validation
103 passedgit diff --check: passedThe repository-wide suite was not rerun after the final review fixes; prior full-suite runs contained known baseline failures outside this patch. The affected test set above was rerun from the final commit state.
Live verification scope
An earlier pre-review revision was manually deployed to the single authorized live target.
/healthand dry-run returned 200. One authorized live run returned 200 and submitted one DAY limit order with statusSubmitted; no read-only/API-321 failure was observed. This confirms submission, not fill.The current head, including the what-if permission probe and subsequent Codex review fixes, has not been redeployed. Its evidence is the local validation and PR checks above; the normal deployment pipeline can replace the manual deployment after merge.