refactor(notifications): migrate to shared renderer_base - #315

Merged

Pigbibi merged 7 commits into

mainfrom

refactor/notification-unification

Jul 8, 2026

Pigbibi commented Jul 8, 2026

Collaborator

Summary

Replace locally duplicated functions with imports from quant_platform_kit.notifications.renderer_base.

Depends on: QuantPlatformKit#200

Changes

notifications/renderers.py: 962 → 709 lines (-253)
Deleted local copies of 22 shared functions (formatting, text splitting, volatility helpers, etc.)
Kept thin wrappers for IBKR-specific patterns:
- _build_timing_audit_lines — uses resolve_execution to flatten nested execution_annotations
- _relabel_dashboard_cash_labels — delegates to shared with translator=None (IBKR uses hardcoded labels)
- _build_tqqq_risk_control_lines — delegates to shared
- _format_signal_snapshot_line — delegates to shared with IBKR-specific localize_text callback
All platform-specific functions preserved (order formatting, batch builders, build_dashboard, etc.)
Renderer public API unchanged

🤖 Generated with Claude Code

Pigbibi and others added 3 commits

July 9, 2026 04:17


          feat(rebalance): record execution telemetry via PerformanceMonitor

28d4556

Persist IBKR execution summaries after each strategy cycle using
QuantPlatformKit try_record_platform_execution().

Co-Authored-By: Claude <noreply@anthropic.com>
Co-authored-by: Cursor <cursoragent@cursor.com>


          fix(ci): align QPK pin with canonical 0af622a after #199 merge

98a877e

Co-Authored-By: Claude <noreply@anthropic.com>
Co-authored-by: Cursor <cursoragent@cursor.com>


          refactor(notifications): migrate to shared renderer_base (-253 lines)

a144315

Replace locally duplicated functions with imports from
quant_platform_kit.notifications.renderer_base.
Keep thin wrappers for IBKR-specific data access patterns
(e.g. execution_annotations flattening, hardcoded cash labels).

Co-Authored-By: Claude <noreply@anthropic.com>

cursor Bot commented Jul 8, 2026

Bugbot is not enabled for your account, so this pull request was not reviewed.

Enable Bugbot in the Cursor dashboard to get automatic reviews on future PRs.

This comment has been minimized.

Sign in to view

Pigbibi enabled auto-merge (squash)

July 8, 2026 21:12

cursor Bot commented Jul 8, 2026

Bugbot is not enabled for your account, so this pull request was not reviewed.

Enable Bugbot in the Cursor dashboard to get automatic reviews on future PRs.


          chore: bump QPK pin to 8378e93 for notification renderer_base

cb1c711

Co-Authored-By: Claude <noreply@anthropic.com>

cursor Bot commented Jul 8, 2026

Bugbot is not enabled for your account, so this pull request was not reviewed.

Enable Bugbot in the Cursor dashboard to get automatic reviews on future PRs.

Pigbibi and others added 2 commits

July 9, 2026 05:17


          fix(execution): universal whole-share retention rule for small accounts

2efb862

Replace the per-symbol hardcoded whitelist with a universal rule:
if the account already holds a symbol (>0 shares) AND the strategy
wants to keep >= 85% of 1 share's value, retain the position.

Co-Authored-By: Claude <noreply@anthropic.com>


          Merge remote-tracking branch 'origin/main' into refactor/notification…

ba85c1a

…-unification

# Conflicts:
#	pyproject.toml

cursor Bot commented Jul 8, 2026

Bugbot is not enabled for your account, so this pull request was not reviewed.

Enable Bugbot in the Cursor dashboard to get automatic reviews on future PRs.


          fix: restore QPK pin to 8378e93 after merge conflict resolution

ebdaceb

Co-Authored-By: Claude <noreply@anthropic.com>

cursor Bot commented Jul 8, 2026

Bugbot is not enabled for your account, so this pull request was not reviewed.

Enable Bugbot in the Cursor dashboard to get automatic reviews on future PRs.

Pigbibi merged commit 021d4fb into main

2 checks passed

Pigbibi deleted the refactor/notification-unification branch

July 8, 2026 21:36

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet