Skip to content

Commit 30b671d

Browse files
Pigbibicodex
andcommitted
Fix Cloud Run warmup health route
Co-Authored-By: Codex <noreply@openai.com>
1 parent 5a32952 commit 30b671d

2 files changed

Lines changed: 3 additions & 2 deletions

File tree

.github/workflows/sync-cloud-run-env.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1136,7 +1136,7 @@ jobs:
11361136
fi
11371137
11381138
warmup_job_name="${cloud_run_service%-service}-warmup-scheduler"
1139-
warmup_uri="${service_url}/healthz"
1139+
warmup_uri="${service_url}/health"
11401140
if gcloud scheduler jobs describe "${warmup_job_name}" \
11411141
--project="${GCP_PROJECT_ID}" \
11421142
--location="${scheduler_location}" >/dev/null 2>&1; then

tests/test_cloud_run_warmup_workflow.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,9 +6,10 @@ def test_env_sync_creates_non_trading_health_warmup_with_retries() -> None:
66

77
assert 'scheduler.get("probe_time")' in workflow
88
assert 'warmup_job_name="${cloud_run_service%-service}-warmup-scheduler"' in workflow
9-
assert 'warmup_uri="${service_url}/healthz"' in workflow
9+
assert 'warmup_uri="${service_url}/health"' in workflow
1010
assert '--http-method=GET' in workflow
1111
assert '--max-retry-attempts=2' in workflow
1212
assert workflow.count('--max-retry-attempts=2') == 2
1313
assert '--attempt-deadline=60s' in workflow
14+
assert 'warmup_uri="${service_url}/healthz"' not in workflow
1415
assert 'warmup_uri="${service_url}/probe"' not in workflow

0 commit comments

Comments
 (0)