chore(deps): align QPK pin to f0d6bc739943 - #88
Conversation
Automated downstream QPK pin update after QPK_PIN landed on main. Co-Authored-By: Claude <noreply@anthropic.com>
🤖 Codex PR Review✅ Merge allowed: No issues found Review by Codex PR Review bot • PR |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 26db67d9fe
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| dependencies = [ | ||
| "pandas>=2.0", | ||
| "quant-platform-kit @ git+https://github.com/QuantStrategyLab/QuantPlatformKit.git@2381aa4577e9fd6329053a73a1c888929170eaf3", | ||
| "quant-platform-kit @ git+https://github.com/QuantStrategyLab/QuantPlatformKit.git@f0d6bc7399433b9a1ccdaab1f0874faf184cfa84", |
There was a problem hiding this comment.
This changes the install/lock pin to f0d6bc..., but the repository's qsl.toml compatibility manifest still declares quant-platform-kit at 37c81901160c5b31127a27dba1c63944933fb6bf (qsl.toml lines 4-8). In contexts that consume the compat metadata rather than pyproject.toml—and the CI workflow has a dedicated “Check QPK pin and lock consistency” step—this release can still be paired with the older QPK commit instead of the one this dependency bump is meant to align to. Please update the compat manifest to the same ref, or explicitly exclude it from the pin consistency contract.
Useful? React with 👍 / 👎.
| dependencies = [ | ||
| "pandas>=2.0", | ||
| "quant-platform-kit @ git+https://github.com/QuantStrategyLab/QuantPlatformKit.git@2381aa4577e9fd6329053a73a1c888929170eaf3", | ||
| "quant-platform-kit @ git+https://github.com/QuantStrategyLab/QuantPlatformKit.git@f0d6bc7399433b9a1ccdaab1f0874faf184cfa84", |
There was a problem hiding this comment.
The CI workflow's “Check QPK pin and lock consistency” step runs check_qpk_pin_consistency.py --pin-file external/QuantPlatformKit/QPK_PIN, and at QuantPlatformKit@f0d6bc739943... that QPK_PIN contains de18c2e9d93bcfc2220148a99749447059a6f4c6, not f0d6bc739943.... In PR/CI contexts that check out that QPK revision (or current QPK main with the same pin manifest), this line and the matching uv.lock entries will be reported as mismatches against the canonical pin, so the dependency check fails before tests run. Please pin this repo to the SHA from QPK_PIN and regenerate the lockfile.
Useful? React with 👍 / 👎.
|
Superseded: downstream pin sync must update qsl.toml compatibility metadata together with pyproject.toml and uv.lock. |
1 participant
Summary
f0d6bc739943uv.lock，同步刷新 lockfileTest plan
🤖 Generated with Claude Code