Skip to content

Default implementation of FS.islink is probably wrong #425

@althonos

Description

@althonos

The current implementation of fs.base.FS.islink is the following:

    def islink(self, path):
        self.getinfo(path)
        return False

Because of this, and contrary to FS.isdir and FS.isfile, a filesystem implementation simply relying on the type attribute in the details namespace of getinfo to convey a file type will not work. This probably affects TarFS in this library.

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions