diff --git a/lib/src/main/java/com/team2813/lib2813/control/Motor.java b/lib/src/main/java/com/team2813/lib2813/control/Motor.java index 56cc95be..c0cfad08 100644 --- a/lib/src/main/java/com/team2813/lib2813/control/Motor.java +++ b/lib/src/main/java/com/team2813/lib2813/control/Motor.java @@ -45,6 +45,22 @@ public interface Motor { */ Current getAppliedCurrent(); - /** Stops the motor. */ - void disable(); + /** + * Stops the motor. + * + * @deprecated Use {@link #stopMotor()}. + */ + @Deprecated + default void disable() { + stopMotor(); + } + + /** + * Stops the motor. + * + * @since 2.0.0 + */ + default void stopMotor() { + set(ControlMode.VOLTAGE, 0); + } } diff --git a/lib/src/main/java/com/team2813/lib2813/control/motors/SparkMaxWrapper.java b/lib/src/main/java/com/team2813/lib2813/control/motors/SparkMaxWrapper.java index 0743b7a1..27308856 100644 --- a/lib/src/main/java/com/team2813/lib2813/control/motors/SparkMaxWrapper.java +++ b/lib/src/main/java/com/team2813/lib2813/control/motors/SparkMaxWrapper.java @@ -97,7 +97,7 @@ public Current getAppliedCurrent() { } @Override - public void disable() { + public void stopMotor() { motor.stopMotor(); } diff --git a/lib/src/main/java/com/team2813/lib2813/control/motors/TalonFXWrapper.java b/lib/src/main/java/com/team2813/lib2813/control/motors/TalonFXWrapper.java index 15d2e92b..6882dbed 100644 --- a/lib/src/main/java/com/team2813/lib2813/control/motors/TalonFXWrapper.java +++ b/lib/src/main/java/com/team2813/lib2813/control/motors/TalonFXWrapper.java @@ -202,8 +202,8 @@ public void setNeutralMode(NeutralModeValue mode) { * @see TalonFXWrapper#setNeutralMode(NeutralModeValue) */ @Override - public void disable() { - motor.disable(); + public void stopMotor() { + motor.stopMotor(); } @Override diff --git a/lib/src/main/java/com/team2813/lib2813/subsystems/MotorSubsystem.java b/lib/src/main/java/com/team2813/lib2813/subsystems/MotorSubsystem.java index f3969981..b996514a 100644 --- a/lib/src/main/java/com/team2813/lib2813/subsystems/MotorSubsystem.java +++ b/lib/src/main/java/com/team2813/lib2813/subsystems/MotorSubsystem.java @@ -142,9 +142,7 @@ public final boolean atPosition() { */ @Override public void set(ControlMode mode, double demand, double feedForward) { - if (isEnabled()) { - disable(); - } + isEnabled = false; motor.set(mode, demand, feedForward); } @@ -154,7 +152,7 @@ public Current getAppliedCurrent() { } /** - * Engages the PID Controller. + * Engages the PID controller. * *
The motor voltage will be periodically updated to move the motor towards the current * setpoint. @@ -172,9 +170,10 @@ public void enable() { *
The motor voltage will be set to zero, and the motor will not adjust to move towards the * current setpoint. */ - public void disable() { + @Override + public void stopMotor() { isEnabled = false; - motor.disable(); + motor.stopMotor(); } /** diff --git a/testing/src/main/java/com/team2813/lib2813/testing/FakeMotor.java b/testing/src/main/java/com/team2813/lib2813/testing/FakeMotor.java index cbd39c3f..8880ec16 100644 --- a/testing/src/main/java/com/team2813/lib2813/testing/FakeMotor.java +++ b/testing/src/main/java/com/team2813/lib2813/testing/FakeMotor.java @@ -81,7 +81,7 @@ public double getFeedForward() { } @Override - public void disable() { + public void stopMotor() { if (controlMode != ControlMode.MOTION_MAGIC) { set(controlMode, 0); }