omar-polo
yesterday
this is not a NEEDACK importer, so results should be nil. The importer is not touching it at all.
(nit; but it makes the code shorter, and it avoids a false understanding when going back to this later :p)
omar-polo
yesterday
since i'm commenting already, a small nit here would be to use struct{} instead of bool: it takes up less space! not interesting at all for tests, but it's a matter of using the "best" option for future reference :p
omar-polo
yesterday
this is not a NEEDACK importer, so results should be nil. The importer is not touching it at all.
(nit; but it makes the code shorter, and it avoids a false understanding when going back to this later :p)
omar-polo
yesterday
since i'm commenting already, a small nit here would be to use struct{} instead of bool: it takes up less space! not interesting at all for tests, but it's a matter of using the "best" option for future reference :p