Skip to content

Two fastify request-JSON parity tests crash under --filter json, tracked by nothing #7658

Description

@proggeramlug

test_issue_1240_fastify_request_json and test_issue_1293_fastify_request_json crash (not parity-fail) under the parity harness's --filter json selection. Both are fastify HTTP-server tests.

Found incidentally while re-measuring #7478 on the pinned quiet mini: 35 tests matched --filter json, 33 passed, 0 parity-failed, and these 2 crashed. Reproduced on the mini's unmodified origin/main checkout, so they are pre-existing and were not caused by the change under test (a docs-only diff).

Why this is worth a ticket rather than a note

Neither test appears in test-parity/known_failures.json or gap_snapshot.json, so nothing tracks them and nothing goes red on them. They are also not in the 12 test_gap_*json* tests that the JSON work routinely runs — they only surface under a broader --filter json, which is why a whole campaign of JSON work (#7477, #7483, #7499, #7537, #7539, #7546, #7478) never saw them.

A crash is a stronger signal than a parity failure: it is a wrong answer that could not even finish producing itself. Two of them, in the same subsystem, unattributed.

What to establish first

  1. Whether they crash on a dev host too, or only on the mini — the mini's toolchain differs (it carries z3 4.16 and needs install_name_tool repointing for the compiler driver, per the gc-ratchet artifact's provenance notes).
  2. Whether the crash is in fastify's request handling or in JSON parsing reached through it. If the latter, it belongs with the tape work; if the former, it is an HTTP-server bug that merely mentions JSON.
  3. Whether they ever passed — git log on the test files plus a spot-check at an older tag would say whether this is a regression or has never worked.

Do not add them to known_failures.json before (3): that file is a ratchet since #7599, and an entry without a known provenance is the suppression it replaced.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions