Migrate new admin Organization to TypeScript with features and documentation migration risks #518
Merged
Merged
Conversation
|
@jnnzz is attempting to deploy a commit to the PSITS-UCMAIN's projects Team on Vercel. A member of the Team first needs to authorize it. |
Javabutdif
approved these changes
May 26, 2026
There was a problem hiding this comment.
Pull request overview
This PR migrates the Admin “Organization” feature into the TypeScript client, wiring it into the admin router/sidebar and introducing new Organization UI + data-fetching logic, along with updated migration documentation and minor admin UI tweaks.
Changes:
- Added a new
/admin/organizationpage with a full OrganizationView + supporting hook/types underfeatures/admin/organization. - Wired the Organization page into the admin router and sidebar navigation.
- Expanded admin API typings and adjusted one toast message; updated migration-plan documentation with post-implementation findings.
Reviewed changes
Copilot reviewed 12 out of 12 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| docs/ADMIN_FRONTEND_TS_MIGRATION_PLAN.md | Adds post-implementation findings/risks for the TS admin migration plan. |
| client-side-ts/src/router.tsx | Adds the /admin/organization route to the admin router. |
| client-side-ts/src/pages/admin/Organization.tsx | New admin page wrapper that renders OrganizationView. |
| client-side-ts/src/features/admin/organization/types/organization.types.ts | Introduces Organization feature TypeScript types (tabs, sorting, models, forms). |
| client-side-ts/src/features/admin/organization/index.ts | Exposes the Organization feature module exports. |
| client-side-ts/src/features/admin/organization/hooks/useOrganizationData.ts | Implements Organization data loading, filtering, sorting, pagination, and actions. |
| client-side-ts/src/features/admin/organization/components/OrganizationView.tsx | Implements the Organization UI (tabs, table, dialogs, bulk actions). |
| client-side-ts/src/features/admin/organization/components/index.ts | Exports OrganizationView. |
| client-side-ts/src/features/admin/index.ts | Re-exports the new Organization subfeature from the admin feature barrel. |
| client-side-ts/src/features/admin/dashboard/components/DashboardView.tsx | Adds cursor/disabled pointer behavior styling for dashboard buttons. |
| client-side-ts/src/features/admin/components/AdminSidebar.tsx | Updates admin nav icons/styles and adds an Organization link (with UC-Main UI restriction). |
| client-side-ts/src/features/admin/api/admin.ts | Broadens typings for member/request records and tweaks decline-role success toast message. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
101
to
103
| { path: "dashboard", Component: Dashboard }, | ||
| { path: "organization", Component: Organization }, | ||
| { path: "events", Component: EventsPage }, |
Comment on lines
+173
to
+176
| const fetchAccounts = useCallback(async () => { | ||
| setIsLoading(true); | ||
| setError(null); | ||
|
|
| } finally { | ||
| setIsLoading(false); | ||
| } | ||
| }, [activeTab]); |
| <ul className="space-y-1"> | ||
| <li> | ||
| <Tooltip> | ||
| <Tooltip open={false}> |
Comment on lines
+345
to
+347
| <tr | ||
| key={`${activeTab}-${account.id_number}`} | ||
| className="border-b border-[#ededed] text-[#303030]" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.