From 094b932e03903c3353904361d8247644ddd0a911 Mon Sep 17 00:00:00 2001 From: GabrielFcGoncalves Date: Mon, 18 May 2026 18:33:44 +0000 Subject: [PATCH 1/2] OTP SMTP update --- api/src/services/keycloak_admin/user_handler.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/api/src/services/keycloak_admin/user_handler.py b/api/src/services/keycloak_admin/user_handler.py index 7236300..e0c1296 100644 --- a/api/src/services/keycloak_admin/user_handler.py +++ b/api/src/services/keycloak_admin/user_handler.py @@ -105,7 +105,7 @@ def add_user( user_id = location.rstrip("/").split("/")[-1] # Trigger "Update Password" email - kc.execute_actions_email(realm_name, token, user_id, ["UPDATE_PASSWORD"]) + # kc.execute_actions_email(realm_name, token, user_id, ["UPDATE_PASSWORD"]) # Determine org manager flag from requested role is_org_manager = (role or "").strip().upper() == "ORG_MANAGER" From fcc8eb1dc623a489fe33f4069e7addba0084563e Mon Sep 17 00:00:00 2001 From: GabrielFcGoncalves Date: Mon, 18 May 2026 18:38:11 +0000 Subject: [PATCH 2/2] OTP SMTP update --- .../services/test_keycloak_admin_coverage.py | 38 +++++++++---------- api/test/services/test_user_handler.py | 6 +-- 2 files changed, 22 insertions(+), 22 deletions(-) diff --git a/api/test/services/test_keycloak_admin_coverage.py b/api/test/services/test_keycloak_admin_coverage.py index e5f8a4e..9ed5ae3 100644 --- a/api/test/services/test_keycloak_admin_coverage.py +++ b/api/test/services/test_keycloak_admin_coverage.py @@ -77,25 +77,25 @@ def test_create_realm_with_smtp_and_required_actions(mock_kc): assert payload["clients"] == template["clients"] assert payload["users"] == template["users"] -def test_add_user_triggers_email(mock_kc): - # Arrange - uh = user_handler() - session = MagicMock() - - mock_response = MagicMock( - status_code=201, - headers={"Location": "http://keycloak/u/123"} - ) - mock_kc.create_user.return_value = mock_response - mock_kc.get_realm_role.return_value = {"id": "r1"} - - # Act - uh.add_user(session, "realm", "user", "pass", "Full Name", "user@test.com", "ORG_MANAGER") - - # Assert - mock_kc.execute_actions_email.assert_called_once_with( - "realm", ANY, "123", ["UPDATE_PASSWORD"] - ) +# def test_add_user_triggers_email(mock_kc): +# # Arrange +# uh = user_handler() +# session = MagicMock() +# +# mock_response = MagicMock( +# status_code=201, +# headers={"Location": "http://keycloak/u/123"} +# ) +# mock_kc.create_user.return_value = mock_response +# mock_kc.get_realm_role.return_value = {"id": "r1"} +# +# # Act +# uh.add_user(session, "realm", "user", "pass", "Full Name", "user@test.com", "ORG_MANAGER") +# +# # Assert +# mock_kc.execute_actions_email.assert_called_once_with( +# "realm", ANY, "123", ["UPDATE_PASSWORD"] +# ) def test_add_user_location_missing(mock_kc): uh = user_handler() diff --git a/api/test/services/test_user_handler.py b/api/test/services/test_user_handler.py index eb769a9..d814546 100644 --- a/api/test/services/test_user_handler.py +++ b/api/test/services/test_user_handler.py @@ -131,9 +131,9 @@ def test_create_user_success(service, mock_kc, session: Session): # Assert assert res["status"] == "created" assert res["username"] == "john.doe" - mock_kc.execute_actions_email.assert_called_once_with( - realm_name, "token", "123", ["UPDATE_PASSWORD"] - ) + # mock_kc.execute_actions_email.assert_called_once_with( + # realm_name, "token", "123", ["UPDATE_PASSWORD"] + # ) # Verify DB db_user = session.get(User, "123")