Skip to content

This mod redefines ImmunityGainSpeed instead of patching it #26

Description

@thailyn

(The Steam workshop page says I should tag @emipa606 regarding bug reports.)

I noticed that this mod has a StatDef for ImmunityGainSpeed (located here), which essentially replaces the original def in the Core module. As I think is well known by now (but maybe not back when this mod was first created), it is a Bad Idea to make changes to a def this way, instead of patching it.

I see the version defined in this mod has some changes relative to the original, such as changing the importance of the pawn's blood filtration and age on the stat. But, I don't see anywhere where this stat is referenced in this mod (though I haven't done a thorough search, so I easily could be missing something), so I'm curious why this stat is being redefined/modified in the first place. There's a comment near setting showOnMechanoids to false, so I expect that was a major point to the modification, but that value is also false in the Core module.

So, first, this StatDef should be replaced by patches to achieve the end result wanted by this mod. Second, could you provide an explanation for why this stat is being modified by this mod? The link between mechanoids and immunity gain speed is not immediately apparent to me. Is it a balancing tweak? Can it be made optional? Thanks!

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions