From 3f77681d1d2115f20f1ee1ea2986f89cb6b9c7a9 Mon Sep 17 00:00:00 2001 From: Matthias Kuehlewein Date: Fri, 19 Jun 2026 19:25:53 +0200 Subject: [PATCH 1/3] DuplicateEqualsTest: Fix comparison of area symbols --- test/duplicate_equals_t.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/test/duplicate_equals_t.cpp b/test/duplicate_equals_t.cpp index 77ad010ad..1390d4390 100644 --- a/test/duplicate_equals_t.cpp +++ b/test/duplicate_equals_t.cpp @@ -60,7 +60,7 @@ void testDecoupling(const AreaSymbol& a, const AreaSymbol& b) { auto& pattern_a = a.getFillPattern(i); auto& pattern_b = b.getFillPattern(i); - QVERIFY(&a != &b); + QVERIFY(&pattern_a != &pattern_b); switch (pattern_a.type) { case AreaSymbol::FillPattern::LinePattern: From 22d34132d294847c75a19e9b4240eecd5db1f3a0 Mon Sep 17 00:00:00 2001 From: Matthias Kuehlewein Date: Fri, 19 Jun 2026 19:42:09 +0200 Subject: [PATCH 2/3] PathObjectTest: Fix copy and paste error --- test/path_object_t.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/test/path_object_t.cpp b/test/path_object_t.cpp index 17e62c3b4..fe89c3ecd 100644 --- a/test/path_object_t.cpp +++ b/test/path_object_t.cpp @@ -909,7 +909,7 @@ void PathObjectTest::calcIntersectionsTest() parallel3.addCoordinate(MapCoord(30, -10)); PathObject::Intersections intersections_parallel_se; - intersections_parallel.reserve(2); + intersections_parallel_se.reserve(2); intersection.coord = MapCoordF(20, 0); intersection.length = 10; From 53fcec5d35a9d709d1c902fbb7a06dcda29cf476 Mon Sep 17 00:00:00 2001 From: Matthias Kuehlewein Date: Fri, 19 Jun 2026 20:50:31 +0200 Subject: [PATCH 3/3] FileFormatTest: Fix variable type deduction Fix type deduction where subtracting two unsigned functions resulted in an unsigned auto variable, ignoring negative results. This underflow had no negative side effects because QString::fill() expects a signed parameter, implicitly converting values near UINT_MAX back to the correct negative numbers. --- test/file_format_t.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/test/file_format_t.cpp b/test/file_format_t.cpp index 0f64f8cda..a58adebdd 100644 --- a/test/file_format_t.cpp +++ b/test/file_format_t.cpp @@ -169,7 +169,7 @@ namespace } \ else \ { \ - auto const diff = qstrlen(#b) - qstrlen(#a); \ + int const diff = qstrlen(#b) - qstrlen(#a); \ auto const fill_a = QString().fill(QChar::Space, +diff); \ auto const fill_b = QString().fill(QChar::Space, -diff); \ QFAIL(QString::fromLatin1( \