Incorrect Action Executed In OMList.doAction()

[jose-m-torres]

In the OMList.doAction() method the OMGraphicConstants.LOWER_TO_BOTTOM_GRAPHIC_MASK action calls the moveIndexedOneToBottom() method instead of moveIndexedToBottom().

Both OMGraphicConstants.LOWER_TO_BOTTOM_GRAPHIC_MASK and OMGraphicConstants.LOWER_GRAPHIC_MASK currently perform the same action to moveIndexedOneToBottom().

I verified that correctly calling moveIndexedToBottom() when the mask is set to OMGraphicConstants.LOWER_TO_BOTTOM_GRAPHIC_MASK works as expected.

The issue exists in the currently available download version, OpenMap 5.1.15.

The correction is the following inside the OMList.doAction() method:

if (action.isMask(LOWER_TO_BOTTOM_GRAPHIC_MASK)) {
    Debug.message("omgl", "OMGraphicList.doAction: lowering graphic to bottom");
    moveIndexedToBottom(i); // -> Corrected by Jose M. Torres
}

[dfdietrick]

Thanks for the fix Jose! I appreciate you sending it in. - Don

…

On Sep 17, 2021, at 12:42 PM, jose-m-torres ***@***.***> wrote: In the OMList.doAction() method the OMGraphicConstants.LOWER_TO_BOTTOM_GRAPHIC_MASK action calls the moveIndexedOneToBottom() method instead of moveIndexedToBottom(). Both OMGraphicConstants.LOWER_TO_BOTTOM_GRAPHIC_MASK and OMGraphicConstants.LOWER_GRAPHIC_MASK currently perform the same action to moveIndexedOneToBottom(). I verified that correctly calling moveIndexedToBottom() when the mask is set to OMGraphicConstants.LOWER_TO_BOTTOM_GRAPHIC_MASK works as expected. The issue exists in the currently available download version, OpenMap 5.1.15. The correction is the following inside the OMList.doAction() method: if (action.isMask(LOWER_TO_BOTTOM_GRAPHIC_MASK)) { Debug.message("omgl", "OMGraphicList.doAction: lowering graphic to bottom"); moveIndexedToBottom(i); // -> Corrected by Jose M. Torres } — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub, or unsubscribe. Triage notifications on the go with GitHub Mobile for iOS or Android.