test(tools): cover JSON export CI vs TTY progress reporting#262
Draft
cursor[bot] wants to merge 1 commit into
Draft
test(tools): cover JSON export CI vs TTY progress reporting#262cursor[bot] wants to merge 1 commit into
cursor[bot] wants to merge 1 commit into
Conversation
Co-authored-by: Boden <th3w1zard1@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds focused unit tests for
_supports_live_progressand_ExportProgressReporterinresource_json.py, matching the regression fix fromfix(json-export): log progress when automated; casefold stream path assert(CI /GITHUB_ACTIONSmust force logger-based milestones instead of\rstderr updates even when stderr reports as a TTY).Type of Change
Package(s) Affected
Changes Made
Libraries/PyKotor/tests/tools/test_resource_json_progress.pywith seven tests covering:_supports_live_progressreturnsFalsewhenCIorGITHUB_ACTIONSis set to truthy values (including case/whitespace), even if the stream claims to be a TTY.logger.infoand the fake TTY stream receives no\routput.Risky behavior now covered
caplog-style tests see progress; stderr\rupdates must not be the only signal.Test files added/updated
Libraries/PyKotor/tests/tools/test_resource_json_progress.pyWhy these tests materially reduce regression risk
They pin the contract between environment detection (
CI/GITHUB_ACTIONS) and progress delivery (logger vs raw stream). A future refactor could easily reintroduce “TTY-only” progress and silently break CI logs and tests that assert on logged percentages, without failing in local development.Testing
Test Results
(Run with
PYTHONPATHincludingLibraries/PyKotor/srcandUtility/src, and PyKotor runtime deps installed.)Checklist
Related Issues
Related to automated regression coverage for JSON export / installation-to-json workflows.