test(resource-json): regression coverage for CI vs TTY export progress#260
Draft
cursor[bot] wants to merge 1 commit into
Draft
test(resource-json): regression coverage for CI vs TTY export progress#260cursor[bot] wants to merge 1 commit into
cursor[bot] wants to merge 1 commit into
Conversation
Co-authored-by: Boden <th3w1zard1@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds focused unit tests for
_supports_live_progressinresource_json, matching the behavior introduced infix(json-export): log progress when automated; casefold stream path assert(commit c7e573d). WhenCIorGITHUB_ACTIONSis set, live\rprogress on stderr is disabled so percentage milestones go through the logger (visible to caplog and log aggregators). When those env vars are unset, behavior falls back tostream.isatty().Type of Change
Package(s) Affected
Changes Made
Libraries/PyKotor/tests/test_resource_json_progress.pywith parametrized checks forCI/GITHUB_ACTIONStruthy values, TTY vs non-TTY streams, and streams withoutisatty.Testing
Test Results
Risky behavior now covered
CI/GITHUB_ACTIONSguard would again use live carriage-return updates on a pseudo-TTY, hiding progress from structured logs and breaking tests that assert onlogger.infopercentage lines.Test files added/updated
Libraries/PyKotor/tests/test_resource_json_progress.pyWhy these tests materially reduce regression risk
They pin the contract between automation environment detection and progress reporting. That path is easy to break when refactoring
_ExportProgressReporteror stderr handling, and the failure mode (silent or invisible progress in CI) is subtle and expensive to catch manually.Checklist
Related Issues
Related to regression-test coverage automation (cron).
Additional Notes
Tests use
monkeypatchfor env vars and smallStringIOsubclasses so they stay deterministic and independent of the host CI environment.