test(cli): cover JSON export live-progress CI env gates#257
Draft
cursor[bot] wants to merge 1 commit into
Draft
Conversation
Co-authored-by: Boden <th3w1zard1@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds unit tests for
_supports_live_progressinresource_json.py, which gates whether installation JSON export uses live\rstderr updates versuslogger.infomilestones. Recent production changes treatCI/GITHUB_ACTIONSas forcing the logger path so CI and log aggregators reliably capture percentage progress.Type of Change
Package(s) Affected
Risky behavior now covered
CIorGITHUB_ACTIONSis truthy (true/1/yes, case-insensitive). Tests assertFalseis returned for a fake TTY stream under those env vars, andTruewhen they are unset and the stream reports a TTY.Falsewhenisatty()is false and CI env is clear (unchanged path, guards regressions).Test files added/updated
Libraries/PyKotor/tests/cli/test_json_commands.py— three tests: CI vs TTY interaction, whitespace/case onCI, non-TTY stream.Why this reduces regression risk
This logic is easy to break with a small refactor (e.g. reordering
isattyvs env checks) and has direct impact on observability and the existing caplog-based CLI test for percentage milestones. Deterministic tests usemonkeypatchonly; no network or filesystem dependencies.Testing
Ran (from
Libraries/PyKotorwith dev venv):QT_QPA_PLATFORM=offscreen .venv/bin/python -m pytest --import-mode=importlib -m "not gui and not slow" tests/cli/test_json_commands.py -k "supports_live_progress" -vResult: 3 passed.
Test Results