test(resource): regression coverage for JSON export CI progress#255
Draft
cursor[bot] wants to merge 1 commit into
Draft
test(resource): regression coverage for JSON export CI progress#255cursor[bot] wants to merge 1 commit into
cursor[bot] wants to merge 1 commit into
Conversation
Co-authored-by: Boden <th3w1zard1@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds unit tests for
_supports_live_progressand_ExportProgressReporterso installation/directory JSON export keeps emitting percentage milestones through the logger whenCIorGITHUB_ACTIONSis set, even if stderr appears as a TTY (matching the fix infix(json-export): log progress when automated).Type of Change
Package(s) Affected
Changes Made
Libraries/PyKotor/tests/resource/test_resource_json_ci_progress.pycovering:CI=truedisables live\rprogress even for TTY-like streamsGITHUB_ACTIONS=1does the same whenCIis unsetCI=falsedoes not force the logger path for a TTY stream_ExportProgressReporterlogs percent lines and does not write carriage-return progress to the streamRisky behavior now covered
CI/GITHUB_ACTIONSguard and relies only onisatty().Test files added/updated
Libraries/PyKotor/tests/resource/test_resource_json_ci_progress.pyWhy this reduces regression risk
Large installation JSON exports are long-running; operators rely on logs. The production change intentionally routes progress through
logger.infoin automation. These tests pin that contract without depending on a real TTY orRobustLoggersingleton behavior (subclassingRobustLoggerin tests is unsafe because of its metaclass).Testing
Related Issues
Related to automated regression coverage for merged
resource_jsonexport progress behavior.