Purpose
PR #17 (feat/phase5-retired-corpus, tip c6cdb60) was closed — it was a divergent sibling of #15 that stripped ~700 lines including the fail-closed veto-hardening (deserialize_required_veto). See team review (Echo + Cody + Kitty): #17 must not merge as-is.
However, #17 contained genuinely valuable retired-ward corpus test fixtures worth salvaging into a future PR rebased cleanly onto #15 (which keeps the veto-hardening):
crates/coven-threads-core/tests/phase5_retired_ward_corpus.rs (239 lines)crates/coven-threads-core/tests/support/phase5_retired_ward_corpus.rs (228 lines)crates/coven-threads-core/examples/generate_phase5_retired_ward_corpus.rs (8 lines)
Total ~467 lines of corpus fixtures.
How to recover
The closed branch feat/phase5-retired-corpus (tip c6cdb60) still holds these. Cherry-pick just the corpus files onto a fresh branch off #15's merged state:
git show c6cdb60:crates/coven-threads-core/tests/phase5_retired_ward_corpus.rs > <path>
# ...for each of the 3 files above
Do NOT bring over #17's approval.rs / audit.rs / identity_invariants.rs changes — those are the regression. Corpus fixtures only.
Gate
Land only AFTER #15 merges. Verify fixtures compile against #15's veto-hardened types (they may need updating to the deserialize_required_veto shape).
Owner: Echo drives semantic validation; mechanical cherry-pick is safe once #15 is in.
Purpose
PR #17 (
feat/phase5-retired-corpus, tipc6cdb60) was closed — it was a divergent sibling of #15 that stripped ~700 lines including the fail-closed veto-hardening (deserialize_required_veto). See team review (Echo + Cody + Kitty): #17 must not merge as-is.However, #17 contained genuinely valuable retired-ward corpus test fixtures worth salvaging into a future PR rebased cleanly onto #15 (which keeps the veto-hardening):
crates/coven-threads-core/tests/phase5_retired_ward_corpus.rs(239 lines)crates/coven-threads-core/tests/support/phase5_retired_ward_corpus.rs(228 lines)crates/coven-threads-core/examples/generate_phase5_retired_ward_corpus.rs(8 lines)Total ~467 lines of corpus fixtures.
How to recover
The closed branch
feat/phase5-retired-corpus(tipc6cdb60) still holds these. Cherry-pick just the corpus files onto a fresh branch off #15's merged state:Do NOT bring over #17's approval.rs / audit.rs / identity_invariants.rs changes — those are the regression. Corpus fixtures only.
Gate
Land only AFTER #15 merges. Verify fixtures compile against #15's veto-hardened types (they may need updating to the
deserialize_required_vetoshape).Owner: Echo drives semantic validation; mechanical cherry-pick is safe once #15 is in.