openamp: add new ops wait_notified() to avoid looping in tx buffer get#518
Merged
Conversation
Contributor
Author
Collaborator
|
I suppose that this one is related to #347, right? |
Contributor
Author
CV-Bowen
force-pushed
the
rpmsg_wait_notify
branch
from
869698b to
8fb21ee
Compare
arnopo
requested changes
Oct 19, 2023
arnopo
left a comment
arnopo
left a comment
Collaborator
There was a problem hiding this comment.
Some comments, hoping that I remember well the previous discussions on this subject.
CV-Bowen
force-pushed
the
rpmsg_wait_notify
branch
3 times, most recently
from
91e639a to
5fc0979
Compare
CV-Bowen
force-pushed
the
rpmsg_wait_notify
branch
from
5fc0979 to
becad0a
Compare
arnopo
requested changes
Oct 24, 2023
arnopo
left a comment
arnopo
left a comment
Collaborator
There was a problem hiding this comment.
few additional minor comments
CV-Bowen
force-pushed
the
rpmsg_wait_notify
branch
from
becad0a to
8e53410
Compare
arnopo
reviewed
Oct 27, 2023
arnopo
left a comment
arnopo
left a comment
Collaborator
There was a problem hiding this comment.
LGTM with a last comment
CV-Bowen
force-pushed
the
rpmsg_wait_notify
branch
from
8e53410 to
4205838
Compare
arnopo
approved these changes
Nov 2, 2023
Collaborator
|
Please, could your review this PR? |
tnmysh
reviewed
Nov 21, 2023
tnmysh
reviewed
Nov 21, 2023
tnmysh
reviewed
Nov 21, 2023
Give users a chance to handle the no tx buffer situation when get tx buffer, with this patch, user can call rproc_virtio_set_wait_notified() to set the wait_notified() callback and this callback function will be called to handle the wait when no tx buffer in tx virtqueue. Signed-off-by: Guiding Li <liguiding1@xiaomi.com> Signed-off-by: Bowen Wang <wangbowen6@xiaomi.com>
CV-Bowen
force-pushed
the
rpmsg_wait_notify
branch
from
4205838 to
83a2875
Compare
xiaoxiang781216
approved these changes
Dec 4, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Give users a chance to handle the no tx buffer situation when get tx buffer, with this patch, user can call rproc_virtio_set_wait_notified() to set the wait_notified() callback and this callback function will be called to handle the wait when no tx buffer in tx virtqueue.