rpmsg: supress broken rpmsg_init_ept API

[arnopo]

The rpmsg_init_ept does not seem to be usable by application but is used internally. The proposal is to mark this API deprecated API and in at least two full release, to remove this API as the standard API to use is rpmsg_create_ept.
In parallel, the online function must be moved to rpmsg_internal.h

Issue entered in reference to :

• Fix the wrong address usage #204 (comment)

• rpmsg: move rpmsg_init_ept to lib/rpmsg/rpmsg_internal.h #208 (review)

[arnopo]

Hi @ed,
Proposal is to use similar mechanism as one used in zephyr (https://docs.zephyrproject.org/latest/development_process/api_lifecycle.html)
Introducing the deprecated attribute ( supported by gcc and IAR) allows to continue to use the API, but with a warning at compilation time:
warning: ‘rpmsg_init_ept’ is deprecated [-Wdeprecated-declarations]

To deprecate a function we just need to update the function declaration in the API header:

-static inline void rpmsg_init_ept(struct rpmsg_endpoint *ept,
+__deprecated static inline void rpmsg_init_ept(struct rpmsg_endpoint *ept,

and the "-Wno-deprecated-declarations" compilation option can disable the warning on need.

What is your feeling about this solution?
i plan to send associated PR tomorrow if this looks good to you.

[edmooring]

Hi @arnopo,
This seems to me to be a good solution.