feat: [SDK-4728] support disabling OneSignal location module#1952
Closed
fadi-george wants to merge 5 commits into
Closed
feat: [SDK-4728] support disabling OneSignal location module#1952fadi-george wants to merge 5 commits into
fadi-george wants to merge 5 commits into
Conversation
Collaborator
Author
|
Closing in favor of split stacked PRs: one for the core disable-location support and one for the no-location demo. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
One Line Summary
Adds build-time support for excluding the native OneSignal location module and includes a runnable no-location demo app.
Details
Motivation
Apps that do not use
OneSignal.Locationshould be able to avoid linking the native location module so iOS and Android builds do not include location-related native dependencies or permissions.Scope
This PR adds opt-out controls for the native location module:
$OneSignalDisableLocation = trueswitches CocoaPods to the non-location OneSignal subspecs.OneSignal_disableLocation=trueswitches Gradle to individual OneSignal modules withoutcom.onesignal:location.examples/demo-no-locationdemonstrates push/in-app usage without location permissions or location module linkage.Testing
Unit testing
No new unit tests in this repo. The change is primarily native dependency selection and bridge behavior, validated through example app builds.
Manual testing
vp run iosinexamples/demo-no-location; app built and launched successfully.vp run androidinexamples/demo-no-location; app built, installed, and launched successfully.vp exec tsc --noEmitinexamples/demo-no-location.OneSignalLocation.Affected code checklist
Checklist
Overview
Testing
Final pass
Made with Cursor