From 0b32d169da87c57571848a1a01f5060ed53960f7 Mon Sep 17 00:00:00 2001 From: shakedregev Date: Fri, 29 May 2026 10:46:35 -0400 Subject: [PATCH 1/3] removed old function names --- CHANGELOG.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index ad503b2e..8ebc0553 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -16,7 +16,7 @@ - Added `cons` counterparts to `Vector::getData` methods. -- Made Vector::copyDataTo able to copy from device to host and vice versa +- Made Vector::copyToExternal able to copy from device to host and vice versa - Added `diagSolve`, `max`, and `abs` vector operations. From 17d4ea8b209d2a8b670c23dfcc11b66d31643739 Mon Sep 17 00:00:00 2001 From: shakedregev Date: Fri, 29 May 2026 12:05:40 -0400 Subject: [PATCH 2/3] removed unnecessary synchronization --- resolve/GramSchmidt.cpp | 7 ------- resolve/GramSchmidt.hpp | 1 - 2 files changed, 8 deletions(-) diff --git a/resolve/GramSchmidt.cpp b/resolve/GramSchmidt.cpp index 2e488e62..c8935dcd 100644 --- a/resolve/GramSchmidt.cpp +++ b/resolve/GramSchmidt.cpp @@ -187,26 +187,21 @@ namespace ReSolve vector_handler_->gemv('T', i + 1, ONE, ZERO, V, vec_v_, vec_Hcolumn_, memspace_); // V(:,i+1) = V(:, i+1) - V(:,1:i)*Hcol vector_handler_->gemv('N', i + 1, ONE, MINUS_ONE, V, vec_Hcolumn_, vec_v_, memspace_); - mem_.deviceSynchronize(); // copy H_col to aux, we will need it later vec_Hcolumn_->setDataUpdated(memspace_); vec_Hcolumn_->resize(i + 1); vec_Hcolumn_->copyToExternal(h_aux_, 0, memory::HOST, memory::HOST); - mem_.deviceSynchronize(); // Hcol = V(:,1:i)^T*V(:,i+1); vector_handler_->gemv('T', i + 1, ONE, ZERO, V, vec_v_, vec_Hcolumn_, memspace_); - mem_.deviceSynchronize(); // V(:,i+1) = V(:, i+1) - V(:,1:i)*Hcol vector_handler_->gemv('N', i + 1, ONE, MINUS_ONE, V, vec_Hcolumn_, vec_v_, memspace_); - mem_.deviceSynchronize(); // copy H_col to H vec_Hcolumn_->setDataUpdated(memspace_); vec_Hcolumn_->copyToExternal(&H[idxmap(i, 0, num_vecs_ + 1)], 0, memory::HOST, memory::HOST); - mem_.deviceSynchronize(); // add both pieces together (unstable otherwise, careful here!!) t = 0.0; @@ -381,13 +376,11 @@ namespace ReSolve vector_handler_->gemv('T', i + 1, ONE, ZERO, V, vec_v_, vec_Hcolumn_, memspace_); // V(:,i+1) = V(:, i+1) - V(:,1:i)*Hcol vector_handler_->gemv('N', i + 1, ONE, MINUS_ONE, V, vec_Hcolumn_, vec_v_, memspace_); - mem_.deviceSynchronize(); // copy H_col to H vec_Hcolumn_->setDataUpdated(memspace_); vec_Hcolumn_->resize(i + 1); vec_Hcolumn_->copyToExternal(&H[idxmap(i, 0, num_vecs_ + 1)], 0, memory::HOST, memory::HOST); - mem_.deviceSynchronize(); t = vector_handler_->dot(vec_v_, vec_v_, memspace_); // set the last entry in Hessenberg matrix diff --git a/resolve/GramSchmidt.hpp b/resolve/GramSchmidt.hpp index 1a366cca..53729b15 100644 --- a/resolve/GramSchmidt.hpp +++ b/resolve/GramSchmidt.hpp @@ -53,7 +53,6 @@ namespace ReSolve vector_type* vec_w_{nullptr}; // aux variable vector_type* vec_x_{nullptr}; // aux variable - MemoryHandler mem_; ///< Device memory manager object memory::MemorySpace memspace_; }; From 16ab43433c7c5e5e4fdea937e955f7239b3784ca Mon Sep 17 00:00:00 2001 From: shakedregev Date: Fri, 29 May 2026 12:08:55 -0400 Subject: [PATCH 3/3] Changelog updates --- CHANGELOG.md | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 8ebc0553..2ab775f6 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -16,12 +16,16 @@ - Added `cons` counterparts to `Vector::getData` methods. -- Made Vector::copyToExternal able to copy from device to host and vice versa +- Made Vector::copyToExternal able to copy from device to host and vice versa. - Added `diagSolve`, `max`, and `abs` vector operations. - Improved coding guidelines for developers on floating point conventions. +- Removed unnecessary device synchronization. + +- Changed variable and function names to be more explanatory. + ## Changes to Re::Solve in release 0.99.2 ### Major Features