diff --git a/ebos/eclbaseaquifermodel.hh b/ebos/eclbaseaquifermodel.hh index de5f80638b1..51f1aff7844 100644 --- a/ebos/eclbaseaquifermodel.hh +++ b/ebos/eclbaseaquifermodel.hh @@ -27,10 +27,12 @@ #ifndef EWOMS_ECL_BASE_AQUIFER_MODEL_HH #define EWOMS_ECL_BASE_AQUIFER_MODEL_HH -#include - +#include +#include #include +#include + #include #include #include diff --git a/opm/simulators/aquifers/BlackoilAquiferModel_impl.hpp b/opm/simulators/aquifers/BlackoilAquiferModel_impl.hpp index 98713b27b0b..fbab07de6a1 100644 --- a/opm/simulators/aquifers/BlackoilAquiferModel_impl.hpp +++ b/opm/simulators/aquifers/BlackoilAquiferModel_impl.hpp @@ -22,6 +22,8 @@ #include +#include + #include #include #include diff --git a/opm/simulators/flow/BlackoilModelEbos.hpp b/opm/simulators/flow/BlackoilModelEbos.hpp index a53bb07d0f8..cc90cf423f6 100644 --- a/opm/simulators/flow/BlackoilModelEbos.hpp +++ b/opm/simulators/flow/BlackoilModelEbos.hpp @@ -25,7 +25,6 @@ #define OPM_BLACKOILMODELEBOS_HEADER_INCLUDED #include -#include #include #include @@ -52,13 +51,11 @@ #include #include #include +#include #include #include -#include -#include #include -#include #include @@ -66,9 +63,9 @@ #include #include #include -#include #include #include +#include #include #include @@ -161,7 +158,7 @@ namespace Opm { { public: // --------- Types and enums --------- - typedef BlackoilModelParametersEbos ModelParameters; + using ModelParameters = BlackoilModelParametersEbos; using Simulator = GetPropType; using Grid = GetPropType; @@ -173,42 +170,42 @@ namespace Opm { using Indices = GetPropType; using MaterialLaw = GetPropType; using MaterialLawParams = GetPropType; - - typedef double Scalar; - static const int numEq = Indices::numEq; - static const int contiSolventEqIdx = Indices::contiSolventEqIdx; - static const int contiZfracEqIdx = Indices::contiZfracEqIdx; - static const int contiPolymerEqIdx = Indices::contiPolymerEqIdx; - static const int contiEnergyEqIdx = Indices::contiEnergyEqIdx; - static const int contiPolymerMWEqIdx = Indices::contiPolymerMWEqIdx; - static const int contiFoamEqIdx = Indices::contiFoamEqIdx; - static const int contiBrineEqIdx = Indices::contiBrineEqIdx; - static const int contiMicrobialEqIdx = Indices::contiMicrobialEqIdx; - static const int contiOxygenEqIdx = Indices::contiOxygenEqIdx; - static const int contiUreaEqIdx = Indices::contiUreaEqIdx; - static const int contiBiofilmEqIdx = Indices::contiBiofilmEqIdx; - static const int contiCalciteEqIdx = Indices::contiCalciteEqIdx; - static const int solventSaturationIdx = Indices::solventSaturationIdx; - static const int zFractionIdx = Indices::zFractionIdx; - static const int polymerConcentrationIdx = Indices::polymerConcentrationIdx; - static const int polymerMoleWeightIdx = Indices::polymerMoleWeightIdx; - static const int temperatureIdx = Indices::temperatureIdx; - static const int foamConcentrationIdx = Indices::foamConcentrationIdx; - static const int saltConcentrationIdx = Indices::saltConcentrationIdx; - static const int microbialConcentrationIdx = Indices::microbialConcentrationIdx; - static const int oxygenConcentrationIdx = Indices::oxygenConcentrationIdx; - static const int ureaConcentrationIdx = Indices::ureaConcentrationIdx; - static const int biofilmConcentrationIdx = Indices::biofilmConcentrationIdx; - static const int calciteConcentrationIdx = Indices::calciteConcentrationIdx; - - typedef Dune::FieldVector VectorBlockType; - typedef typename SparseMatrixAdapter::MatrixBlock MatrixBlockType; - typedef typename SparseMatrixAdapter::IstlMatrix Mat; - typedef Dune::BlockVector BVector; + using Scalar = GetPropType; + + static constexpr int numEq = Indices::numEq; + static constexpr int contiSolventEqIdx = Indices::contiSolventEqIdx; + static constexpr int contiZfracEqIdx = Indices::contiZfracEqIdx; + static constexpr int contiPolymerEqIdx = Indices::contiPolymerEqIdx; + static constexpr int contiEnergyEqIdx = Indices::contiEnergyEqIdx; + static constexpr int contiPolymerMWEqIdx = Indices::contiPolymerMWEqIdx; + static constexpr int contiFoamEqIdx = Indices::contiFoamEqIdx; + static constexpr int contiBrineEqIdx = Indices::contiBrineEqIdx; + static constexpr int contiMicrobialEqIdx = Indices::contiMicrobialEqIdx; + static constexpr int contiOxygenEqIdx = Indices::contiOxygenEqIdx; + static constexpr int contiUreaEqIdx = Indices::contiUreaEqIdx; + static constexpr int contiBiofilmEqIdx = Indices::contiBiofilmEqIdx; + static constexpr int contiCalciteEqIdx = Indices::contiCalciteEqIdx; + static constexpr int solventSaturationIdx = Indices::solventSaturationIdx; + static constexpr int zFractionIdx = Indices::zFractionIdx; + static constexpr int polymerConcentrationIdx = Indices::polymerConcentrationIdx; + static constexpr int polymerMoleWeightIdx = Indices::polymerMoleWeightIdx; + static constexpr int temperatureIdx = Indices::temperatureIdx; + static constexpr int foamConcentrationIdx = Indices::foamConcentrationIdx; + static constexpr int saltConcentrationIdx = Indices::saltConcentrationIdx; + static constexpr int microbialConcentrationIdx = Indices::microbialConcentrationIdx; + static constexpr int oxygenConcentrationIdx = Indices::oxygenConcentrationIdx; + static constexpr int ureaConcentrationIdx = Indices::ureaConcentrationIdx; + static constexpr int biofilmConcentrationIdx = Indices::biofilmConcentrationIdx; + static constexpr int calciteConcentrationIdx = Indices::calciteConcentrationIdx; + + using VectorBlockType = Dune::FieldVector; + using MatrixBlockType = typename SparseMatrixAdapter::MatrixBlock; + using Mat = typename SparseMatrixAdapter::IstlMatrix; + using BVector = Dune::BlockVector; using Domain = SubDomain; - typedef ISTLSolverEbos ISTLSolverType; + using ISTLSolverType = ISTLSolverEbos; class ComponentName { @@ -273,8 +270,6 @@ namespace Opm { std::vector names_{}; }; - //typedef typename SolutionVector :: value_type PrimaryVariables ; - // --------- Public methods --------- /// Construct the model. It will retain references to the @@ -437,7 +432,7 @@ namespace Opm { std::fill(wasSwitched_.begin(), wasSwitched_.end(), false); if (param_.update_equations_scaling_) { - std::cout << "equation scaling not supported yet" << std::endl; + OpmLog::error("Equation scaling not supported"); //updateEquationsScaling(); } @@ -934,15 +929,6 @@ namespace Opm { - void printIf(int c, double x, double y, double eps, std::string type) { - if (std::abs(x-y) > eps) { - std::cout << type << " " < - std::tuple convergenceReduction(const CollectiveCommunication& comm, + std::tuple convergenceReduction(Parallel::Communication comm, const double pvSumLocal, const double numAquiferPvSumLocal, std::vector< Scalar >& R_sum, @@ -1711,7 +1696,7 @@ namespace Opm { std::vector& residual_norms) { OPM_TIMEBLOCK(getReservoirConvergence); - typedef std::vector< Scalar > Vector; + using Vector = std::vector; const int numComp = numEq; Vector R_sum(numComp, 0.0 ); diff --git a/opm/simulators/flow/FlowMainEbos.hpp b/opm/simulators/flow/FlowMainEbos.hpp index 601844b7e63..2599a4e4ae9 100644 --- a/opm/simulators/flow/FlowMainEbos.hpp +++ b/opm/simulators/flow/FlowMainEbos.hpp @@ -29,6 +29,8 @@ #include #include +#include + #if HAVE_DUNE_FEM #include #else