From 267d5cdf64d05e22e8357a8971c44c94cc872aed Mon Sep 17 00:00:00 2001 From: Wolfgang Walther Date: Tue, 12 Aug 2025 10:58:45 +0200 Subject: [PATCH] workflows/eval: fix compare job not running The conclusion of the `versions` job propagates from through `eval` to `compare`, which meant the `compare` job was skipped. No rebuild labels, no reviewer requests. Also, we don't want to run eval when `versions` runs, but fails. --- .github/workflows/eval.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/eval.yml b/.github/workflows/eval.yml index 1ac9c846e6f05..53ad022a559f0 100644 --- a/.github/workflows/eval.yml +++ b/.github/workflows/eval.yml @@ -57,7 +57,7 @@ jobs: eval: runs-on: ubuntu-24.04-arm needs: versions - if: ${{ !cancelled() }} + if: ${{ !cancelled() && !failure() }} strategy: fail-fast: false matrix: @@ -197,7 +197,7 @@ jobs: compare: runs-on: ubuntu-24.04-arm needs: [eval] - if: needs.eval.outputs.targetRunId + if: needs.eval.outputs.targetRunId && !cancelled() && !failure() permissions: statuses: write timeout-minutes: 5