Build failure: gdb on darwin

[mio-19]

Nixpkgs version

Please select a version.

Steps to reproduce

build gdb

gdb is a dependency of vscode-extension-ms-vscode-cpptools-1.28.3 on my system

Can Hydra reproduce this build failure?

Yes, Hydra can reproduce this build failure.

Link to Hydra build job

https://hydra.nixos.org/build/319904434

Relevant log output

CC       cpu-s390.lo
  CC       cpu-sh.lo
  CC       cpu-score.lo
  CC       cpu-sparc.lo
  CC       cpu-spu.lo
  CC       cpu-tic30.lo
  CC       cpu-tic4x.lo
../../bfd/cpu-tic4x.c:37:23: error: non-overlapping comparisons always evaluate to false [-Werror,-Wtautological-overlap-compare]
   37 |   if (string[1] < '0' && string[1] > '9')
      |       ~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~
  CC       cpu-tic54x.lo
1 error generated.
  CC       cpu-tic6x.lo
make[4]: *** [Makefile:1758: cpu-tic4x.lo] Error 1
make[4]: *** Waiting for unfinished jobs....
  CC       cpu-tilegx.lo

Additional context

No response

System metadata

• system: "aarch64-darwin"
• host os: Darwin 24.6.0, macOS 15.7.4
• multi-user?: yes
• sandbox: no
• version: nix-env (Lix, like Nix) 2.93.3 System type: aarch64-darwin Additional system types: x86_64-darwin Features: gc, signed-caches System configuration file: /etc/nix/nix.conf User configuration files: /Users/user/.config/nix/nix.conf:/Users/user/.nix-profile/etc/xdg/nix/nix.conf:/etc/profiles/per-user/user/etc/xdg/nix/nix.conf:/run/current-system/sw/etc/xdg/nix/nix.conf:/nix/var/nix/profiles/default/etc/xdg/nix/nix.conf Store directory: /nix/store State directory: /nix/var/nix Data directory: /nix/store/98457fs34arnx4davas2zcsnb5lzcjsp-lix-2.93.3/share
• nixpkgs: /nix/store/0fss98zylksrdnrqsws3ml39y5lwzvxj-source

Notify maintainers

@nbp @globin @lsix

---

Note for maintainers: Please tag this issue in your pull request description. (i.e. Resolves #ISSUE.)

I assert that this issue is relevant for Nixpkgs

• I assert that this is a bug and not a support request.
• I assert that this is not a duplicate of an existing issue.
• I assert that I have read the NixOS Code of Conduct and agree to abide by it.

Is this issue important to you?

Add a 👍 reaction to issues you find important.

[bpopovych]

This is fixed in upstream: https://sourceware.org/git/?p=binutils-gdb.git;a=patch;h=dece3865c2d6420e8193598a33e8a9cd71598547

But after applying this patch another error occurs when building gdb:

checking for sys/stat.h... ../../opcodes/z80-dis.c:807:41: error: 'sprintf' is deprecated: This function is provided for compatibility reasons only. Due to security concerns inherent in the design of sprintf(3), it is highly recommended that you use snprintf(3) instead. [-Werror,-Wdeprecated-declarations]

[Eveeifyeve]

@vcunat the build in hydra is not truly fixed, See https://hydra.nixos.org/build/323359788 for the logs.

[vcunat]

Ah, OK. I only looked at aarch64-darwin which is green now. I guess we keep this open then, though it's disputable as the error log looks different at a glance 🤷🏽

[Eveeifyeve]

@vcunat I think there might be a missing c-include somewhere for x86_64-darwin. But my question is how does it work on aarch64-darwin and where is it called from?

[vcunat]

I'm trying to avoid darwin, so I don't know much about it. We're dropping x86_64-darwin on unstable in about two months, too.