From ad6f4a06efb81fe2b43aad94c86ebd40defd4b3c Mon Sep 17 00:00:00 2001 From: Andrew Seier Date: Mon, 22 Sep 2025 21:48:58 -0700 Subject: [PATCH] Run GitHub test actions on contributor forks. MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Previously, the action in “test.yaml” only ran on branch pushes from maintainers. This was mostly fine, but contributors weren’t getting the same feedback about linting, typing, and testing. Now, all PRs will cause tests to run. Plus, we continue to specifically target our “main” branch updates as a sanity check. Closes #324. --- .github/workflows/check-branch.yaml | 6 ------ .github/workflows/check-main.yaml | 8 ++++++++ .github/workflows/check-pull-request.yaml | 7 +++++++ ts/x-template.d.ts.map | 2 +- x-template.js | 2 +- 5 files changed, 17 insertions(+), 8 deletions(-) delete mode 100644 .github/workflows/check-branch.yaml create mode 100644 .github/workflows/check-main.yaml create mode 100644 .github/workflows/check-pull-request.yaml diff --git a/.github/workflows/check-branch.yaml b/.github/workflows/check-branch.yaml deleted file mode 100644 index 50aaa0b..0000000 --- a/.github/workflows/check-branch.yaml +++ /dev/null @@ -1,6 +0,0 @@ -# Run tests on pushes to all branches. -name: Check Branch -on: [push] -jobs: - test: - uses: ./.github/workflows/test.yaml diff --git a/.github/workflows/check-main.yaml b/.github/workflows/check-main.yaml new file mode 100644 index 0000000..73fb538 --- /dev/null +++ b/.github/workflows/check-main.yaml @@ -0,0 +1,8 @@ +# Run tests on pushes to main branch. +name: Check Main +on: + push: + branches: [main] +jobs: + test: + uses: ./.github/workflows/test.yaml diff --git a/.github/workflows/check-pull-request.yaml b/.github/workflows/check-pull-request.yaml new file mode 100644 index 0000000..60cc014 --- /dev/null +++ b/.github/workflows/check-pull-request.yaml @@ -0,0 +1,7 @@ +# Run tests on pull requests, including from forks. +name: Check Pull Request +on: + pull_request +jobs: + test: + uses: ./.github/workflows/test.yaml diff --git a/ts/x-template.d.ts.map b/ts/x-template.d.ts.map index 23a0e3d..37807d5 100644 --- a/ts/x-template.d.ts.map +++ b/ts/x-template.d.ts.map @@ -1 +1 @@ -{"version":3,"file":"x-template.d.ts","sourceRoot":"","sources":["../x-template.js"],"names":[],"mappings":"AAm4BA,yBAA2E;AAC3E,uBAAuE;AAGvE,4BAAiF;AACjF,yBAA2E"} \ No newline at end of file +{"version":3,"file":"x-template.d.ts","sourceRoot":"","sources":["../x-template.js"],"names":[],"mappings":"AA+3BA,yBAA2E;AAC3E,uBAAuE;AAGvE,4BAAiF;AACjF,yBAA2E"} \ No newline at end of file diff --git a/x-template.js b/x-template.js index ee71822..94bc168 100644 --- a/x-template.js +++ b/x-template.js @@ -808,7 +808,7 @@ class TemplateEngine { // } // } static #removeWithin(node) { - node.replaceChildren() + node.replaceChildren(); } // TODO: Future state — we may choose to iterate differently as an