Fix settings page scrolling on short/mobile viewports#98
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Description
src/views/Settings.vueCSS to make.settings-wrappera scroll container by replacingmin-height: 100vhwithheight: 100dvhand addingoverflow-y: auto.box-sizing: border-boxto avoid padding increasing the visual height and addtouch-action: pan-yand-webkit-overflow-scrolling: touchto enable mobile touch scrolling and momentum.Testing
npm run buildwhich completed successfully.npx playwright install chromiumandnpx playwright install-deps chromiumwhich succeeded./#/sthat checked.settings-wrapperstyles and attempted programmatic scrolling; the wrapper reportedoverflowY: "auto"andtouchAction: "pan-y", and a small-viewport run showedscrollTopchanged from0to215, confirming scrollability.Codex Task