Split == and isequal methods for MatrixElem#2421
Draft
lgoettgens wants to merge 3 commits into
Draft
Conversation
26175ec to
61e74ad
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #2280.
This currently contains #2420, as that is needed for everything to kind of work.
Current state
Triage needs to decide between the following scenarios:
MatElemandMatRingElemthrows an explicit error.false(if there was a promotion possible, see the last sentence in Splitpromotemethods forMatrixElem#2420 (comment)).MatElemandMatRingElemunpacks the MatRingElem and uses the underlying matrix for the comparison. What about the case that the coefficient rings are different? Do we want to do the promotion on the level ofMatElems for this? (x-ref the failing test)Option 1 is definitely "breaking", option 2 maybe.
Needed work
For possibilities 1 and 2, there are a few "FIXME" comments in the code that need to be addressed.
For possibility 3, one would need to add a workaround for the failing test.