Add Puiseux polynomials#2391
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2391 +/- ##
==========================================
- Coverage 88.12% 87.59% -0.53%
==========================================
Files 128 129 +1
Lines 32886 33084 +198
==========================================
Hits 28981 28981
- Misses 3905 4103 +198 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
The test file needs to be included explicitly to be executed (there is no magic like in OSCAR). I assume it could fit in the list of |
|
@lgoettgens Good point, I suggest we remove these for now and once this PR is merged and a new release of AA has happened, I will open a PR in OSCAR. |
Co-authored-by: Lars Göttgens <lars.goettgens@gmail.com>
Removed trivial tests from the PuiseuxPolynomials test suite.
|
We plan to do a new release soonish. Do you guys want to get it in? Not sure what the status is here. I still see some "Oscar" references in the test code. |
|
@ollieclarke8787 Do you have some time to finish the pull request at the beginning of next week? |
Definitely, I think we just need to remove the Oscar references from the tests, everything else should still be working. |
|
Update: Most parts work as intended. Two remaining issues:
|
Co-authored-by: Martin Wagner <martin.wagner.dev@gmail.com>
Working repository for adding Puiseux Polynomials to AA, this should supersede oscar-system/Oscar.jl#5861