Add AbstractAlgebra.is_ijulia_inited and an IJulia extension driving it#2365
Merged
Conversation
855824f to
c6725d4
Compare
This comment was marked as outdated.
This comment was marked as outdated.
fingolfin
commented
Feb 27, 2026
c6725d4 to
ae99353
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2365 +/- ##
==========================================
- Coverage 88.20% 88.19% -0.01%
==========================================
Files 127 128 +1
Lines 32865 32855 -10
==========================================
- Hits 28987 28978 -9
+ Misses 3878 3877 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Co-authored-by: Codex <codex@openai.com>
ae99353 to
a7691d2
Compare
Member
Author
|
I've now also updated the outdated code comment (or rather I asked codex to update it) |
Member
Author
|
I note that Hecke and Oscar contain similar hacks. Two solutions come to mind:
I tend towards option 1. Any thoughts, @lgoettgens @thofma ? And, shall we merge this? |
AbstractAlgebra.is_ijulia_inited and an IJulia extension
AbstractAlgebra.is_ijulia_inited and an IJulia extensionAbstractAlgebra.is_ijulia_inited and an IJulia extension driving it
Member
|
I vote for (1). |
lgoettgens
reviewed
Mar 2, 2026
Member
|
I am also in favor of (1). We should do another release soon-ish anyway to make #2362 available to downstream users. |
lgoettgens
approved these changes
Mar 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Co-authored-by: Codex codex@openai.com
Resolves #2357