Skip to content

Add AbstractAlgebra.is_ijulia_inited and an IJulia extension driving it#2365

Merged
lgoettgens merged 2 commits into
masterfrom
codex/ijulia-extension
Mar 4, 2026
Merged

Add AbstractAlgebra.is_ijulia_inited and an IJulia extension driving it#2365
lgoettgens merged 2 commits into
masterfrom
codex/ijulia-extension

Conversation

@fingolfin

Copy link
Copy Markdown
Member

Co-authored-by: Codex codex@openai.com

Resolves #2357

@fingolfin fingolfin requested a review from thofma February 27, 2026 10:58
@fingolfin fingolfin force-pushed the codex/ijulia-extension branch from 855824f to c6725d4 Compare February 27, 2026 10:59
@thofma

This comment was marked as outdated.

Comment thread src/PrettyPrinting.jl
@fingolfin fingolfin force-pushed the codex/ijulia-extension branch from c6725d4 to ae99353 Compare February 27, 2026 14:58
@codecov

codecov Bot commented Feb 27, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 0% with 11 lines in your changes missing coverage. Please review.
✅ Project coverage is 88.19%. Comparing base (185b6ce) to head (c2f6354).
⚠️ Report is 5 commits behind head on master.

Files with missing lines Patch % Lines
src/AbstractAlgebra.jl 0.00% 5 Missing ⚠️
src/PrettyPrinting.jl 0.00% 4 Missing ⚠️
ext/IJuliaExt/IJuliaExt.jl 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2365      +/-   ##
==========================================
- Coverage   88.20%   88.19%   -0.01%     
==========================================
  Files         127      128       +1     
  Lines       32865    32855      -10     
==========================================
- Hits        28987    28978       -9     
+ Misses       3878     3877       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Co-authored-by: Codex <codex@openai.com>
@fingolfin fingolfin force-pushed the codex/ijulia-extension branch from ae99353 to a7691d2 Compare February 27, 2026 17:32
@fingolfin

Copy link
Copy Markdown
Member Author

I've now also updated the outdated code comment (or rather I asked codex to update it)

@fingolfin

Copy link
Copy Markdown
Member Author

I note that Hecke and Oscar contain similar hacks. Two solutions come to mind:

  1. let them all use AbstractAlgebra.is_ijulia_inited() (then they need to depend on AA in a suitable version)
  2. let them all add their own package extension with equivalent code (means it can be done immediately, without an AA release).

I tend towards option 1. Any thoughts, @lgoettgens @thofma ? And, shall we merge this?

@fingolfin fingolfin changed the title Add IJulia extension hook for pretty printing Add AbstractAlgebra.is_ijulia_inited and an IJulia extension Mar 2, 2026
@fingolfin fingolfin added the release notes: not needed PRs introducing changes that are wholly irrelevant to the release notes label Mar 2, 2026
@fingolfin fingolfin changed the title Add AbstractAlgebra.is_ijulia_inited and an IJulia extension Add AbstractAlgebra.is_ijulia_inited and an IJulia extension driving it Mar 2, 2026
@thofma

thofma commented Mar 2, 2026

Copy link
Copy Markdown
Member

I vote for (1).

Comment thread ext/IJuliaExt/IJuliaExt.jl Outdated
@lgoettgens

Copy link
Copy Markdown
Member

I am also in favor of (1). We should do another release soon-ish anyway to make #2362 available to downstream users.

@lgoettgens lgoettgens enabled auto-merge (squash) March 4, 2026 13:39
@lgoettgens lgoettgens merged commit 674b1b2 into master Mar 4, 2026
22 of 24 checks passed
@lgoettgens lgoettgens deleted the codex/ijulia-extension branch March 4, 2026 17:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release notes: not needed PRs introducing changes that are wholly irrelevant to the release notes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Move IJulia code into a package extension?

3 participants